feat: add "enrich audit" function#4283
Draft
eric-intuitem wants to merge 2 commits into
Draft
Conversation
Add "Enrich from source" for compliance audits. Merge mapped assessment data from a selected source audit into an existing target audit, reusing the mapping engine (inverse of "Apply Mapping"). Same-framework sources copy 1:1; cross-framework sources map (incl. multi-hop), with a preview-before-apply step. Merge rules: full coverage copies, partial coverage only fills blanks and adds controls, observations are appended idempotently, M2M links are unioned, and source defaults never clobber existing values. Fix mapping-engine coverage: compute multi-hop coverage as weakest-link (previously kept the first hop's coverage), and base the copy decision only on the source audit's own requirements, not intermediate frameworks. Also: clamp negative score-progress that crashed the tree view, full localization (25 locales), tests, and documentation.
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Add "Enrich from source" for compliance audits.
Merge mapped assessment data from a selected source audit into an existing target audit, reusing the mapping engine (inverse of "Apply Mapping"). Same-framework sources copy 1:1; cross-framework sources map (incl. multi-hop), with a preview-before-apply step.
Merge rules: full coverage copies, partial coverage only fills blanks and adds controls, observations are appended idempotently, M2M links are unioned, and source defaults never clobber existing values.
Fix mapping-engine coverage: compute multi-hop coverage as weakest-link (previously kept the first hop's coverage), and base the copy decision only on the source audit's own requirements, not intermediate frameworks.
Also: clamp negative score-progress that crashed the tree view, full localization (25 locales), tests, and documentation.