Merge pull request #146 from invariant-labs/refactor-positions-counter

zielvna · web-flow · commit fb34069ddf2b · 2024-10-10T20:35:17.000+02:00
make contract return alph when the only position on the list is removed
diff --git a/contracts/collections/positions.ral b/contracts/collections/positions.ral
@@ -64,7 +64,11 @@ Abstract Contract Positions(clamm: CLAMM) extends PositionHelper(clamm) {
             positions[key] = lastPosition
             positions.remove!(caller, lastKey)
         }
-        positionsCounter[caller] = length - 1
+        if(length > 1) {
+            positionsCounter[caller] = length - 1
+        } else {
+            positionsCounter.remove!(caller, caller)
+        }
     }
 
     @using(preapprovedAssets = true)

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,11 @@ Abstract Contract Positions(clamm: CLAMM) extends PositionHelper(clamm) {`
`64`	`64`	`positions[key] = lastPosition`
`65`	`65`	`positions.remove!(caller, lastKey)`
`66`	`66`	`}`
`67`		`- positionsCounter[caller] = length - 1`
	`67`	`+ if(length > 1) {`
	`68`	`+ positionsCounter[caller] = length - 1`
	`69`	`+ } else {`
	`70`	`+ positionsCounter.remove!(caller, caller)`
	`71`	`+ }`
`68`	`72`	`}`
`69`	`73`
`70`	`74`	`@using(preapprovedAssets = true)`