Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subcommunities: comment email on request has wrong link to request URL #1199

Open
slint opened this issue Aug 28, 2024 · 2 comments
Open

subcommunities: comment email on request has wrong link to request URL #1199

slint opened this issue Aug 28, 2024 · 2 comments

Comments

@slint
Copy link
Member

slint commented Aug 28, 2024

When a user comments on a subcommunity inclusion request, the generated email contains a link to the request that uses the /me/requests/{req_id} URL. This might work for other types of requests, but not for this one.

We should instead be rendering a request link to /communities/{slug}/requests/{req_id}.

@slint slint moved this to Ready in Sprint Q4/2024 🎄 Aug 28, 2024
@0einstein0 0einstein0 assigned 0einstein0 and unassigned 0einstein0 Oct 14, 2024
@carlinmack carlinmack changed the title subcommunities: comment email on request have wrong link to request URL subcommunities: comment email on request has wrong link to request URL Oct 30, 2024
@slint
Copy link
Member Author

slint commented Dec 17, 2024

@carlinmack I guess this solved by the comment recipient fixes PRs?

@carlinmack
Copy link
Contributor

carlinmack commented Dec 17, 2024

@slint The membership requests link to /communities/ but the record/draft requests link to /me/ (and the subcom req's link to /communities/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready
Development

No branches or pull requests

3 participants