Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requests: fixing comments notifications for record requests #1903

Open
slint opened this issue Dec 9, 2024 · 0 comments · May be fixed by #1904 or inveniosoftware/invenio-app-rdm#2939
Open

requests: fixing comments notifications for record requests #1903

slint opened this issue Dec 9, 2024 · 0 comments · May be fixed by #1904 or inveniosoftware/invenio-app-rdm#2939

Comments

@slint
Copy link
Member

slint commented Dec 9, 2024 •
edited
Loading

Request comments on draft review and record inclusion requests are not working because the recipients can be communities, that the base comment notification builder cannot resolve to specific user email recipients.

The default set of community recipients should be curators, managers, and owners (since they're the that have permissions to accept/reject record-related requests).

(Note, see how a similar fix was applied at inveniosoftware/invenio-communities#1256)
@slint slint converted this from a draft issue Dec 9, 2024
@slint slint changed the title requests: fixing comments notifications for member and record requests requests: fixing comments notifications for record requests Dec 9, 2024
This was referenced Dec 9, 2024
Open
Open
@carlinmack carlinmack moved this from In progress to In review 🔎 in Sprint Q4/2024 🎄 Dec 11, 2024
@carlinmack carlinmack removed their assignment Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Sprint Q4/2024 🎄
Status: In review 🔎
Milestone
No milestone
2 participants
@slint @carlinmack