Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error-message for importing funders-vocabulary are too vague #219

Open
chriz-uniba opened this issue Sep 7, 2022 · 0 comments
Open

Error-message for importing funders-vocabulary are too vague #219

chriz-uniba opened this issue Sep 7, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@chriz-uniba
Copy link
Contributor

Package version (if known): invenio-app-rdm 9.1.3; invenio-vocabularies 0.11.6

Describe the bug

When importing a funders vocabulary from a zip-file the error-messages are too vague.

Steps to Reproduce

curl https://zenodo.org/api/files/25d4f93f-6854-4dd4-9954-173197e7fad7/v1.1-2022-06-16-ror-data.zip -o funders.zip
# invenio vocabularies import --vocabulary funders --origin funders.zip

FundersServiceWriter: [{'ValidationError': {'identifiers': {0: {'identifier': 'Invalid ISNI identifier.'}}}}]
FundersServiceWriter: [{'ValidationError': {'identifiers': {0: {'identifier': 'Invalid ISNI identifier.'}}}}]
FundersServiceWriter: [{'ValidationError': {'identifiers': {0: {'identifier': 'Invalid ISNI identifier.'}}}}]
FundersServiceWriter: [{'ValidationError': {'identifiers': {0: {'identifier': 'Invalid ISNI identifier.'}}}}]
Vocabulary funders imported. Total items 102742.
102738 items succeeded
4 contained errors
0 were filtered.

Expected behavior

Getting a more detailed information of the ISNIs that were wrong.

Additional thought

Maybe related: error messages wrt. the names.yaml weren't better
#215

@chriz-uniba chriz-uniba added the bug Something isn't working label Sep 7, 2022
@chriz-uniba chriz-uniba changed the title Error-message for importing funders-vocabulary are to vage Error-message for importing funders-vocabulary are too vage Sep 7, 2022
@chriz-uniba chriz-uniba changed the title Error-message for importing funders-vocabulary are too vage Error-message for importing funders-vocabulary are too vague Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant