Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoanMetadata name property mixed types #34

Closed
topless opened this issue Apr 20, 2020 · 1 comment
Closed

LoanMetadata name property mixed types #34

topless opened this issue Apr 20, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@topless
Copy link
Member

topless commented Apr 20, 2020

You will notice when we create the rows for the metadata table, that the name property can be two different things. Either a string or a react component. The name property is also used as a key for our metadata table entries. This triggers the react error, because more than one entry has a key [object Object] (from the object name entries).

@kpsherva kpsherva transferred this issue from inveniosoftware/invenio-app-ils Jun 2, 2020
@kpsherva kpsherva added the bug Something isn't working label Jul 3, 2020
@FlorianCassayre
Copy link
Member

Fixed by #193.
The name property should only be passed a string value; and it makes sense, otherwise it can break the layout. As it turns out, the only use case for having a node was to have an icon before the text, which is a very valid reason. This was addressed by adding an optional icon property (of type node).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants