AlternateIdentifier: value disappeares if duplicated scheme error

[jrcastro2]

Package version (if known): v0.18.0

Describe the bug

While creating a new upload if we fill in the same scheme twice in the "Alternate identifiers" it will throw an error Alternate identifiers: Only one identifier per scheme is allowed. but in the field the values will dissapear.

Note: It happens only when creating the draft for the first time.

Steps to Reproduce

1. Go to 'New upload'
2. Fill in the basic information
3. Add at least 2 "Alternate identifiers" with the same scheme
4. Click 'Save draft'
5. See the error in the banner
6. Scroll down and check the fields, some values disapperead

Expected behavior

Incorrect values should be highlighted with the error message.

Screenshots (if applicable)

Additional context

Also check other ArrayFields such as Related works as they may have the same issue.

Investigation

The issue is coming from the fact that formik's initial values are tightly coupled with the redux state. This is probably not ideal as a solution, initialValues were probably meant to keep the initial state of the form to run the diff on the fields, not to update the state from redux state(which is reflecting the backend's record payload).

As discussed internally, the form should only keep the users actions in the current state and the initialValues from the first loading point.

The record state (redux state) should be decoupled from the formik state, in order to preserve the user's operation history (only user input)

We discussed updating the initialValues only on success response, however it does not work if the error happens even before saving the first draft

[alejandromumo]

Is this issue still blocked? Why was it blocked?

[jrcastro2]

Is this issue still blocked? Why was it blocked?

Needed discussion with Zach, due to holidays we couldn't addressed it before. The main point was to remove one prop from formik (enableReinitialize) and we agreed that it can be removed if we don'f find any bugs after doing an exhaustive testing of the upload form. I will address this during this afternoon most-likely.