Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array field main label #246

Open
Ducica opened this issue Jul 23, 2024 · 0 comments
Open

Array field main label #246

Ducica opened this issue Jul 23, 2024 · 0 comments

Comments

@Ducica
Copy link
Contributor

Ducica commented Jul 23, 2024

There is a problem with ArrayField top level label (main label).

<FieldLabel htmlFor={fieldPath} icon={labelIcon} label={label} />

As there actually isn't an input to which the htmlfor corresponds, it is raising errors in the console

image

This seems to be semantically incorrect way to do things. Probably it would be best if it was wrapped in a <fieldset> tag and <legend> was used instead of the FieldLabel. If you think this is something worth changing, I could look into making a PR for it. Please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant