Skip to content

PF / AzureAD / Graph Integration URLs as customizable fields #8607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
logray opened this issue Mar 28, 2025 · 2 comments · May be fixed by #8612
Open

PF / AzureAD / Graph Integration URLs as customizable fields #8607

logray opened this issue Mar 28, 2025 · 2 comments · May be fixed by #8612

Comments

@logray
Copy link

logray commented Mar 28, 2025

Hello,

I am requesting a feature to make the URLs for AzureAD integration customizable fields, instead of hard-coded in lib/pf/Authentication/Source/AzureADSource.pm (and related).

The hard coded values of "microsoft.com" and "microsoftonline.com" in AzureADSource.pm (and related) prevent other regions/clouds from using this integration.

I have manually hard coded ".us" suffix in lib/pf/Authentication/Source/AzureADSource.pm variables, and using pftest against a test Azure authentication source shows that the integration functions as expected.

Please refer to this link for a list of URLs:

https://learn.microsoft.com/en-us/graph/deployments

Thank you,

-Logan

@jrouzierinverse
Copy link
Member

What line did you change?

@logray
Copy link
Author

logray commented Mar 31, 2025

These three lines in AzureADSource.pm, changed from ".com" to ".us"

27 has 'token_url' => (isa => 'Str', is => 'rw', default => "https://login.microsoftonline.com/%TENANT_ID/oauth2/v2.0/token");
28 has 'user_groups_url' => (isa => 'Str', is => 'rw', default => "https://graph.microsoft.com/v1.0/users/%USERNAME/memberOf");
97 scope => "https://graph.microsoft.com/.default",

And also I changed this line in /lib/pf/services/manager/radiusd_child.pm, but I don't think it is involved in oauth2 (not entirely certain):

900 discovery = "https://login.microsoftonline.com/%{Realm}/v2.0"

@jrouzierinverse jrouzierinverse linked a pull request Apr 3, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants