Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC locked to 1.65.1 while 1.65.5 is installed when not using this repo #116

Open
mikehardy opened this issue Nov 13, 2024 · 4 comments
Open

Comments

@mikehardy
Copy link
Collaborator

There appears to be an ongoing need for manual maintenance on the build script here (in lockstep with manual package/release/tag on the grpc-binary repo) to get new gRPC patches and/or minors when they are released

It seems that to match a typical source install of firestore we should be on 1.65.5 now as cocoapods installs that when not using firestore-ios-sdk-frameworks, but that doesn't exist on grpc-binary repo so it is not currently possible.

I imagine 1.66 or 1.67 (or soon 1.68) of grpc may be the correct transitive dependency of firestore in it's podspec in the future, and that won't exist on grpc-binary either without some intervention there

I opened corresponding / related issue google/grpc-binary#19 on the binary repo as any work to get the current bugfixes (or future features) in grpc ingested here will need work in concert there

@russellwheatley
Copy link
Member

It was a while ago when Mike and I patched this, but I think you're referring to this: https://github.com/invertase/firestore-ios-sdk-frameworks/blob/main/.github/workflows/scripts/extract-versions.sh#L24

We pinned it because the tag was missing for v1.65.0 I believe.

Reference podspec.json: https://github.com/CocoaPods/Specs/blob/master/Specs/3/1/8/FirebaseFirestoreInternal/11.5.0/FirebaseFirestoreInternal.podspec.json#L96

I think we need the upstream issue to be resolved (i.e. gRPC to be tagged properly, for v1.65.5 )which we need to get Package.swift: https://github.com/invertase/firestore-ios-sdk-frameworks/blob/main/.github/workflows/scripts/extract-urls.sh#L11

@mikehardy
Copy link
Collaborator Author

Yep - exactly that - I logged more info in the upstream issue as I agree with you I believe they have to go first by having all necessary / desired tags over there before anything can happen here

@russellwheatley
Copy link
Member

Adding this to remind myself, this FlutterFire issue: firebase/flutterfire#12960

Ought to be fixed in gRPC >= 1.65.2: firebase/firebase-ios-sdk#13115 (comment)

@mikehardy
Copy link
Collaborator Author

@russellwheatley I don't think that compile error applies for library consumers, since they are not compiling gRPC from source so they would never trigger it - it is not triggered when consuming the gRPC binary

That said, any other bugfixes from 1.65.1 through 1.65.5 obviously are not included here since gRPC is pinned to 1.65.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants