From 89904ea9bf945471681b7c584c54468485ce585b Mon Sep 17 00:00:00 2001 From: Mike Hardy Date: Sun, 24 Nov 2024 21:30:50 -0500 Subject: [PATCH] fix(android, app): fix hot-reload on react-native <= 0.73 super.invalidate() is an empty function in rn >= 0.74, so no need to call it going forward But on rn <= 0.73 it may not exist, and if it does it calls onCatalystInstanceDestroy which makes for a StackOverFlowException as we go recursive --- .../io/invertase/firebase/common/ReactNativeFirebaseModule.java | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/app/android/src/reactnative/java/io/invertase/firebase/common/ReactNativeFirebaseModule.java b/packages/app/android/src/reactnative/java/io/invertase/firebase/common/ReactNativeFirebaseModule.java index 57850abd23..4e84bcc949 100644 --- a/packages/app/android/src/reactnative/java/io/invertase/firebase/common/ReactNativeFirebaseModule.java +++ b/packages/app/android/src/reactnative/java/io/invertase/firebase/common/ReactNativeFirebaseModule.java @@ -111,7 +111,6 @@ public void onCatalystInstanceDestroy() { // method did not exist before then @CallSuper public void invalidate() { - super.invalidate(); executorService.shutdown(); }