From ffd168fc09bd5f129e625e7602b87ff9cebd6af8 Mon Sep 17 00:00:00 2001 From: russellwheatley Date: Tue, 19 Nov 2024 16:41:22 +0000 Subject: [PATCH] test: update modular test as well --- packages/crashlytics/e2e/crashlytics.e2e.js | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/packages/crashlytics/e2e/crashlytics.e2e.js b/packages/crashlytics/e2e/crashlytics.e2e.js index 0086cfbd6e..64d8b1e868 100644 --- a/packages/crashlytics/e2e/crashlytics.e2e.js +++ b/packages/crashlytics/e2e/crashlytics.e2e.js @@ -264,10 +264,13 @@ describe('crashlytics()', function () { let logged = false; // eslint-disable-next-line no-console console.warn = msg => { - msg.should.containEql('expects an instance of Error'); - logged = true; - // eslint-disable-next-line no-console - console.warn = orig; + // we console.warn for deprecated API, can be removed when we move to v9 + if (!msg.includes('v8 method is deprecated')) { + msg.should.containEql('expects an instance of Error'); + logged = true; + // eslint-disable-next-line no-console + console.warn = orig; + } }; recordError(getCrashlytics(), 1337);