Why PhoneAuthOptions.newBuilder() has a setTimeout(30L, ...)? #6971
efstathiosntonas
started this conversation in
General
Replies: 1 comment 3 replies
-
Huh - seems like at a minimum, 60 seconds might be better, the 30 came in the original implementation from @fzuellich - perhaps they know? I would be open to a PR that switches it to 60 (having it conform with the docs seems like a reasonable thing...) or with passing props and a default to 60 if no props passed |
Beta Was this translation helpful? Give feedback.
3 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hey @mikehardy, hope you're doing well. Can you please explain why the default setTimeout is set to 30L? The sdk docs have a value of 60L as an example.
Recently we are experiencing many sms expired errors and I was wondering if this value can affect this error. We have a countdown blocker of 30 seconds awaiting for auto-retrieval, when timeout ends and the auto-retrieval failed then the user can enter the code manually (I know this is not recommended but many users were spamming the "resend code" logic).
It could be beneficial to pass a prop for it so users can freely change this? 🤔
Thanks!
Beta Was this translation helpful? Give feedback.
All reactions