feat: Add initial tvOS support to some firebase packages #8109
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
Adds compatibility with tvOS (using react-native-tvos) for RNFirebase packages: app, auth, firestore, functions, storage and app check
| @@ -10,6 +10,7 @@ if coreVersionDetected != coreVersionRequired | |||
| end | |||
| firebase_ios_target = appPackage['sdkVersions']['ios']['iosTarget'] | |||
| firebase_macos_target = appPackage['sdkVersions']['ios']['macosTarget'] | |||
| firebase_tvos_target = appPackage['sdkVersions']['ios']['tvosTarget'] | |||
There was a problem hiding this comment.
You can simplify this and just keep tvOS target the same as iOS.
| @@ -76,7 +76,8 @@ | |||
| "ios": { | |||
| "firebase": "11.4.0", | |||
| "iosTarget": "13.0", | |||
| "macosTarget": "10.15" | |||
| "macosTarget": "10.15", | |||
| "tvosTarget": "12.0" | |||
There was a problem hiding this comment.
This should be 13.4 or higher for compatibility with RNTV 0.73 and later
There was a problem hiding this comment.
Bit of a catch :) If we use firebase_ios_target for tvOS then there isn't a way set tvosTarget to to 13.4 without also setting iosTarget, which I'm not sure we want to do when most users aren't targeting tvOS?
There was a problem hiding this comment.
I'm okay with having these separate, and we align the minimums with the firebase-ios-sdk podspecs not with react-native. The Auth podspec over there is the highest one so it determines all, and it is currently at 13.0:
So in final form what I will do here is keep them separate, but bump to 13.0
|
I couldn't push to this fork:branch combo with my fixups so I've posted them all here: I will close this PR but obviously it is the base of that one - if you could head over there and check the add-on commits to see the changes I made, I think they should work? You can grab the patch set for testing via patch-package by following the details link on the CI patch-package workflow and looking at the summary there |
Adds compatibility with tvOS (using react-native-tvos) for RNFirebase packages: app, auth, firestore, functions, storage and app check
Description
Two main changes:
RNFBAuthModule.mto only remove incompatible tvOS APIsThis allows running the updated Firebase packages on tvOS.
Related issues
Not aware of an open issue but discussion here:
#5722 (comment)
Release Summary
Adds compatibility with tvOS (using react-native-tvos) for RNFirebase packages: app, auth, firestore, functions, storage and app check
Checklist
AndroidiOS(well sort of,tvOS)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Not sure how to add a test plan for this change.
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter