Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test release/minified build on Android to validate proguard rules #8157

Open
mikehardy opened this issue Nov 23, 2024 · 1 comment
Open

Test release/minified build on Android to validate proguard rules #8157

mikehardy opened this issue Nov 23, 2024 · 1 comment
Labels

Comments

@mikehardy
Copy link
Collaborator

What feature would you like to see?

There is a really old issue asking for guidance on proguard:

The guidance there is to basically keep all io.invertase classes, but it was never officially documented as far as I know.

That indicates that people are likely using react-native-firebase with proguard enabled and no rules, so it should be working but the only way to know is to test it.

Historically testing proguard-enabled minified release builds has been very difficult because instrumented tests don't work by default with proguard enabled

Just recently this has been figured out though and it's not too hard once you know how to do it - here's how:

The task here is to adopt the changes in that Anki-Android repository for our e2e app and run the app in CI with a minified release mode build. That should surface any problems with proguard so we can fix them via @Keep rules as needed

@mikehardy mikehardy added type: enhancement Implements a new Feature Needs Attention labels Nov 23, 2024
Copy link

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

@github-actions github-actions bot added the Stale label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant