Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(app-check): deprecation warning for v8 API ahead of future major release #8198

Draft
wants to merge 2 commits into
base: v8-deprecations
Choose a base branch
from

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Dec 20, 2024

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 5:05pm

@russellwheatley russellwheatley changed the base branch from main to v8-deprecations December 20, 2024 16:41
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (v8-deprecations@10e618f). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                 @@
##             v8-deprecations    #8198   +/-   ##
==================================================
  Coverage                   ?   71.37%           
==================================================
  Files                      ?      155           
  Lines                      ?     6453           
  Branches                   ?     1475           
==================================================
  Hits                       ?     4605           
  Misses                     ?     1727           
  Partials                   ?      121           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant