-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🐛] Ads Doesn't respond to tap #694
Comments
Have you tried our example from the repository? |
I noticed this too - I just assumed TestAdverts didn't have a click handler (using old architecture expo 52) |
It wasn't with Live Ads behaving the same way. I had the same assumption so I tested to be sure. |
same here 🤔 |
@wbalogun I have noticed the ad attribution thing, and I was able to influence it by playing with the sizing of the ad text - but that remained a worry for me. I was not aware that it had no click handler functioning etc, that's a surprise, so this bears investigation. I won't have time myself for quite a while though - so to set expectations - please please please if this affects you (and I assume it affects everyone paying attention here?) - dig in by adding some logging to the relevant code and try to figure out what's happening (or why clicks aren't happening...). We would welcome a PR and would be happy to review+merge one |
I'm happy to help share the load but it would be useful to get some insight into where to start looking (all this is a bit of a black box to me at the moment) logging the
In particular i've noticed there does not seem to be a navigation URL and the Would we expect to see either of thosein the nativeAd object or would Just trying to figure whether to focus more on the |
NativeAdEventType.CLICKED never fires. Just noting this down to share findings lol |
I'm not going to lie, I have absolutely no idea what's going on here so please get involved if you've got this issue too as i'm unreliable. What I seem to gather is that the & components should be generating a clickable view and this view is not rendering, or click handler is not registered for whatever reason. |
Just to note this issue seems to only be applicable on iOS. Android seems to work as long as you pass in the correct child components. I'm finding that child components are VERY sensitive to what component you pass through. So far only
e.g. the above works while replacing text with I wonder if React19 would perhaps help with this with passable refs. 🤔 Sorry for rambling guys, hopefully this is at least somewhat useful. Again...iOS is still completely borked for me, this is only observations on android |
Running experiments with steps listed and reporting results is science, and it's definitely useful. That usually helps lead to a solution so it's always appreciated! |
What happened?
Ads do not open when clicked on or tapped, I tested on the Simulator and Physical device.
Expected Behaviour:
When the Ads is tapped it should open the CTA link.
Demo:
Ads.not.responding.to.click.mov
Code Example (Same from the Docs)
Platforms
Android and iOS
React Native Info
Are your using Typescript?
package.json
app.json
ios/Podfile
android/build.gradle
android/app/build.gradle
android/settings.gradle
AndroidManifest.xml
The text was updated successfully, but these errors were encountered: