Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app_vhost still doesn't behave the same as when used from internal recipes #18

Open
mikesimons opened this issue Oct 2, 2014 · 0 comments

Comments

@mikesimons
Copy link
Contributor

Internal recipes iterate node[type]['sites'] where type is either nginx or apache.

Defaults are set on these attrs but are not available to the app_vhost definition separately.

Therefore, given a site definition in node['nginx']['sites] and a site definition from a cookbook using app_vhost directly, app_vhost will fail unless all parameters are provided whereas the attr version will work.

The defaults need refactoring (again) to internalize them in to app_vhost. In order to facilitate introspection of the sites attrs, perhaps we should do this in addition to what is there already.

This means that a little bit of redundant logic will occur when using the built in recipes but that resulting behavior should be consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant