Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tawk needs screensharing #37

Open
karth295 opened this issue Mar 26, 2018 · 4 comments
Open

Tawk needs screensharing #37

karth295 opened this issue Mar 26, 2018 · 4 comments

Comments

@karth295
Copy link
Contributor

Janus gives us an api for this: https://janus.conf.meetecho.com/screensharingtest.html as long as we're fine sending either camera video or screenshare video but not both. Sending both would require multiple streams. Also note publishers switching from video to screensharing would need to unpublish their own stream and publish a new one. That might "just work" on the subscriber side.

You would need to download an extension. We can reuse Janus's extension: https://chrome.google.com/webstore/detail/janus-webrtc-screensharin/hapfgfdkleiggjjpfpenajgdnfckjpaj

@karth295
Copy link
Contributor Author

karth295 commented Jan 6, 2020

Turns out as of Chrome 70, you no longer need an extension: https://webrtchacks.com/chrome-screensharing-getdisplaymedia/. Instead there's a new getDisplayMedia function. And Janus already uses this under the hood, so it should be pretty straightforward to use!

@toomim
Copy link
Member

toomim commented Jan 6, 2020 via email

@karth295
Copy link
Contributor Author

karth295 commented Jan 6, 2020

Apparently if you pass {audio: true} you capture computer audio but not microphone audio, but it's pretty simple to just merge the two together: https://paul.kinlan.me/screen-recorderrecording-microphone-and-the-desktop-audio-at-the-same-time/

And then we should be able to publish that merged version up to Janus by creating a new MediaStream object.

Yeah @toomim I'm pretty excited -- I'm going to try this out tonight.

@toomim
Copy link
Member

toomim commented Jan 10, 2020

This looks great. It'll really expand the uses for task. Did you make progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants