fix(labels): prevent clicking a label from triggering onClick twice on several components #16154
ShaneKbuild.yml
on: pull_request
build-core
1m 10s
Matrix: test-core-screenshot
test-core-clean-build
8s
test-core-lint
46s
test-core-spec
38s
verify-screenshots
0s
Matrix: test-angular-e2e
Matrix: test-react-e2e
Matrix: test-react-router-e2e
Matrix: test-vue-e2e
verify-test-angular-e2e
0s
verify-test-react-e2e
0s
verify-test-react-router-e2e
0s
verify-test-vue-e2e
0s
Annotations
4 errors and 20 notices
|
[Mobile Chrome] › src/components/radio/test/a11y/radio.e2e.ts:117:11 › radio: a11y - md/ltr › radio: keyboard navigation - md/ltr › tabbing should switch between radio groups:
src/components/radio/test/a11y/radio.e2e.ts#L122
1) [Mobile Chrome] › src/components/radio/test/a11y/radio.e2e.ts:117:11 › radio: a11y - md/ltr › radio: keyboard navigation - md/ltr › tabbing should switch between radio groups
Error: Timed out 5000ms waiting for expect(locator).toBeFocused()
Locator: locator('#first-group ion-radio').first()
Expected: focused
Received: inactive
Call log:
- expect.toBeFocused with timeout 5000ms
- waiting for locator('#first-group ion-radio').first()
9 × locator resolved to <ion-radio value="huey" role="radio" tabindex="0" aria-checked="true" class="md in-item radio-checked radio-label-placement-start hydrated">Huey</ion-radio>
- unexpected value "inactive"
120 |
121 | await pageUtils.pressKeys('Tab');
> 122 | await expect(firstGroupRadios.nth(0)).toBeFocused();
| ^
123 |
124 | await pageUtils.pressKeys('Tab');
125 | await expect(secondGroupRadios.nth(0)).toBeFocused();
at /ionic/src/components/radio/test/a11y/radio.e2e.ts:122:47
|
|
[Mobile Chrome] › src/components/fab/test/custom-size/fab.e2e.ts:9:9 › fab: custom size - ios/ltr › should position fabs correctly with custom sizes:
src/components/fab/test/custom-size/fab.e2e.ts#L14
1) [Mobile Chrome] › src/components/fab/test/custom-size/fab.e2e.ts:9:9 › fab: custom size - ios/ltr › should position fabs correctly with custom sizes
Error: expect(page).toHaveScreenshot(expected)
4 pixels (ratio 0.01 of all image pixels) are different.
Expected: /ionic/src/components/fab/test/custom-size/fab.e2e.ts-snapshots/fab-custom-size-ios-ltr-Mobile-Chrome-linux.png
Received: /ionic/test-results/src-components-fab-test-cu-339fe-correctly-with-custom-sizes-Mobile-Chrome/fab-custom-size-ios-ltr-actual.png
Diff: /ionic/test-results/src-components-fab-test-cu-339fe-correctly-with-custom-sizes-Mobile-Chrome/fab-custom-size-ios-ltr-diff.png
Call log:
- expect.toHaveScreenshot(fab-custom-size-ios-ltr.png) with timeout 5000ms
- verifying given screenshot expectation
- taking page screenshot
- disabled all CSS animations
- waiting for fonts to load...
- fonts loaded
- 4 pixels (ratio 0.01 of all image pixels) are different.
- waiting 100ms before taking screenshot
- taking page screenshot
- disabled all CSS animations
- waiting for fonts to load...
- fonts loaded
- captured a stable screenshot
- 4 pixels (ratio 0.01 of all image pixels) are different.
12 | await page.setViewportSize(Viewports.tablet.landscape);
13 |
> 14 | await expect(page).toHaveScreenshot(screenshot(`fab-custom-size`));
| ^
15 | });
16 | });
17 | });
at /ionic/src/components/fab/test/custom-size/fab.e2e.ts:14:26
|
|
[Mobile Chrome] › src/components/fab/test/custom-size/fab.e2e.ts:9:9 › fab: custom size - ios/ltr › should position fabs correctly with custom sizes:
src/components/fab/test/custom-size/fab.e2e.ts#L14
1) [Mobile Chrome] › src/components/fab/test/custom-size/fab.e2e.ts:9:9 › fab: custom size - ios/ltr › should position fabs correctly with custom sizes
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(page).toHaveScreenshot(expected)
4 pixels (ratio 0.01 of all image pixels) are different.
Expected: /ionic/src/components/fab/test/custom-size/fab.e2e.ts-snapshots/fab-custom-size-ios-ltr-Mobile-Chrome-linux.png
Received: /ionic/test-results/src-components-fab-test-cu-339fe-correctly-with-custom-sizes-Mobile-Chrome-retry1/fab-custom-size-ios-ltr-actual.png
Diff: /ionic/test-results/src-components-fab-test-cu-339fe-correctly-with-custom-sizes-Mobile-Chrome-retry1/fab-custom-size-ios-ltr-diff.png
Call log:
- expect.toHaveScreenshot(fab-custom-size-ios-ltr.png) with timeout 5000ms
- verifying given screenshot expectation
- taking page screenshot
- disabled all CSS animations
- waiting for fonts to load...
- fonts loaded
- 4 pixels (ratio 0.01 of all image pixels) are different.
- waiting 100ms before taking screenshot
- taking page screenshot
- disabled all CSS animations
- waiting for fonts to load...
- fonts loaded
- captured a stable screenshot
- 4 pixels (ratio 0.01 of all image pixels) are different.
12 | await page.setViewportSize(Viewports.tablet.landscape);
13 |
> 14 | await expect(page).toHaveScreenshot(screenshot(`fab-custom-size`));
| ^
15 | });
16 | });
17 | });
at /ionic/src/components/fab/test/custom-size/fab.e2e.ts:14:26
|
|
[Mobile Firefox] › src/components/toast/test/swipe-gesture/toast.e2e.ts:58:9 › toast: swipe gesture with bottom position - ios/ltr › should swipe down to dismiss with anchor:
src/components/toast/test/swipe-gesture/toast.e2e.ts#L1
1) [Mobile Firefox] › src/components/toast/test/swipe-gesture/toast.e2e.ts:58:9 › toast: swipe gesture with bottom position - ios/ltr › should swipe down to dismiss with anchor
Test timeout of 30000ms exceeded.
|
|
🎭 Playwright Run Summary
216 skipped
229 passed (2.2m)
|
|
🎭 Playwright Run Summary
470 passed (2.6m)
|
|
🎭 Playwright Run Summary
212 skipped
239 passed (2.8m)
|
|
🎭 Playwright Run Summary
481 passed (2.9m)
|
|
🎭 Playwright Run Summary
1 flaky
[Mobile Chrome] › src/components/radio/test/a11y/radio.e2e.ts:117:11 › radio: a11y - md/ltr › radio: keyboard navigation - md/ltr › tabbing should switch between radio groups
462 passed (3.1m)
|
|
🎭 Playwright Run Summary
1 flaky
[Mobile Chrome] › src/components/fab/test/custom-size/fab.e2e.ts:9:9 › fab: custom size - ios/ltr › should position fabs correctly with custom sizes
3 skipped
461 passed (2.9m)
|
|
🎭 Playwright Run Summary
2 skipped
465 passed (3.5m)
|
|
🎭 Playwright Run Summary
581 passed (3.9m)
|
|
🎭 Playwright Run Summary
9 skipped
392 passed (4.2m)
|
|
🎭 Playwright Run Summary
14 skipped
349 passed (4.8m)
|
|
🎭 Playwright Run Summary
5 skipped
505 passed (5.5m)
|
|
🎭 Playwright Run Summary
2 skipped
446 passed (5.8m)
|
|
🎭 Playwright Run Summary
4 skipped
482 passed (5.6m)
|
|
🎭 Playwright Run Summary
2 skipped
460 passed (5.8m)
|
|
🎭 Playwright Run Summary
1 flaky
[Mobile Firefox] › src/components/toast/test/swipe-gesture/toast.e2e.ts:58:9 › toast: swipe gesture with bottom position - ios/ltr › should swipe down to dismiss with anchor
3 skipped
491 passed (6.0m)
|
|
🎭 Playwright Run Summary
6 skipped
457 passed (5.8m)
|
|
🎭 Playwright Run Summary
4 skipped
478 passed (6.2m)
|
|
🎭 Playwright Run Summary
7 skipped
481 passed (6.5m)
|
|
🎭 Playwright Run Summary
5 skipped
464 passed (7.0m)
|
|
🎭 Playwright Run Summary
6 skipped
491 passed (7.4m)
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
ionic-angular
Expired
|
643 KB |
sha256:162418e02a462b9085bc428081f7b2226e6082f95526e41d57e257668e652847
|
|
|
ionic-angular-server
Expired
|
8.54 KB |
sha256:458d7f3132a5bc145fcdaed95527c165169bab84f2584157e1ba36f6f889c921
|
|
|
ionic-core
Expired
|
4.93 MB |
sha256:e7c0ebedb24e06ade8292da4e2d12a982acaf800f8585cb5f2824640205a0c8e
|
|
|
ionic-react
Expired
|
199 KB |
sha256:4eb5896ad059dda0f31925cf6c786d2eaad1cfad3e889d511f2adb573a117f28
|
|
|
ionic-react-router
Expired
|
27.9 KB |
sha256:2c6d032a63f8d367973cd1cd7351a65cae8a051a003aa85707e4a990e2b77df5
|
|
|
ionic-vue
Expired
|
220 KB |
sha256:7e90693702ba7e5644c16b5f453cd2dd53a1e6d04255e0b9d06af3e4ac4abf72
|
|
|
ionic-vue-router
Expired
|
17.1 KB |
sha256:3fe1fb8cddbfef64cb025b7eef6248b5ece692a7816a6140264ccf678055cf60
|
|
|
test-results-1-20
Expired
|
428 KB |
sha256:5b1c8695809d3110dda0765111f3833974d35edd385b5e06762a605b4b70ac15
|
|
|
test-results-10-20
Expired
|
488 KB |
sha256:11f7de1a2978eadea19cb805e1fc123cb983a23b0e9955ca9c38ad1d4f4fa01f
|
|
|
test-results-11-20
Expired
|
1.21 MB |
sha256:bee54d9402c6dedc9dd054aed348cb1a4b9da379f25b59000db029bc9c2338dd
|
|
|
test-results-12-20
Expired
|
403 KB |
sha256:d1c1ff67119aa2be4ca341e8b76eeaca8d0669addc720933498b9f1ca3c45001
|
|
|
test-results-13-20
Expired
|
426 KB |
sha256:b5378f258ac92919c9d74b0dc3fe642c246ebff8d396e52b2265f56627bddf52
|
|
|
test-results-14-20
Expired
|
390 KB |
sha256:ba8314fead677bc19e17655b7b6cd1faa30929f724e5a90b22b9e7f0a6f954b8
|
|
|
test-results-15-20
Expired
|
407 KB |
sha256:2bc50a2075b4a3dd24878ff9e5a285433da754fe1c4700e9097e285b7f4c8d1d
|
|
|
test-results-16-20
Expired
|
453 KB |
sha256:3cd471c6519c44bb60c3f2d10bce96c69f20d5d5ad6d9bc03abb6985183c7edf
|
|
|
test-results-17-20
Expired
|
536 KB |
sha256:21764f997db194cac01de5015916a39980eb6997e8d47a0e4af0e1555a6299d3
|
|
|
test-results-18-20
Expired
|
452 KB |
sha256:0fb67dd8a1f91005a5a9cba677a7ceb2cf5e78baa7cdd8395cafb3ea2d2e2572
|
|
|
test-results-19-20
Expired
|
373 KB |
sha256:157e1e5f2505737e1b6730fac8d4e33e3249e637be78d6a15996009812cafaac
|
|
|
test-results-2-20
Expired
|
460 KB |
sha256:98ce854075ea81bac5ea55ab4d92a19a1a8e57e111c6eca51d714aa027e098e7
|
|
|
test-results-20-20
Expired
|
315 KB |
sha256:e0128ef6aaf2fd0efd54d661b5d88e2c77d7bed6b213c0fd37836d6e2e27d938
|
|
|
test-results-3-20
Expired
|
431 KB |
sha256:2eb940c95edf1af1d18fd27584e55a21de92c61a292a97e93c11154b224dcb49
|
|
|
test-results-4-20
Expired
|
496 KB |
sha256:c983bc4e4a8f5e90aad5c4ac52280e1ee61a795d74d6fea91a728b65bef21f33
|
|
|
test-results-5-20
Expired
|
434 KB |
sha256:d7a29d2ada723ea82e33a75dabe4f48dc211183532a3f5fc324d5501f96807bd
|
|
|
test-results-6-20
Expired
|
1.29 MB |
sha256:710656ab864098a83cd9f6285935802978a15d96a2be32fbef368be454ac1bcc
|
|
|
test-results-7-20
Expired
|
328 KB |
sha256:6d53ffd94ab27379d75ac6ba9d7107c52172db393ff5728233f351834c0fcc54
|
|
|
test-results-8-20
Expired
|
417 KB |
sha256:635a81be91cd3afb88c66091a1d7ad1bc4bfada9b77f75555393a8d55a9824c8
|
|
|
test-results-9-20
Expired
|
2.3 MB |
sha256:aab133222c78a5cfb25f886ca5abda943597f27961df3d29e4c2030b1c94dd28
|
|