fix(modal): prevent browser hang when using ModalController in Angular #17695
ShaneKbuild.yml
on: pull_request
build-core
1m 8s
Matrix: test-core-screenshot
test-core-clean-build
13s
test-core-lint
1m 5s
test-core-spec
43s
verify-screenshots
2s
Matrix: test-angular-e2e
Matrix: test-react-e2e
Matrix: test-react-router-e2e
Matrix: test-vue-e2e
verify-test-angular-e2e
2s
verify-test-react-e2e
3s
verify-test-react-router-e2e
3s
verify-test-vue-e2e
3s
Annotations
1 error and 20 notices
|
[Mobile Safari] › src/components/datetime-button/test/overlays/datetime-button.e2e.ts:11:9 › datetime-button: rendering - ios/ltr › should size the modal correctly:
src/components/datetime-button/test/overlays/datetime-button.e2e.ts#L27
1) [Mobile Safari] › src/components/datetime-button/test/overlays/datetime-button.e2e.ts:11:9 › datetime-button: rendering - ios/ltr › should size the modal correctly
Error: expect(page).toHaveScreenshot(expected) failed
2329 pixels (ratio 0.01 of all image pixels) are different.
Snapshot: datetime-overlay-modal-ios-ltr.png
Call log:
- Expect "toHaveScreenshot(datetime-overlay-modal-ios-ltr.png)" with timeout 5000ms
- verifying given screenshot expectation
- taking page screenshot
- disabled all CSS animations
- waiting for fonts to load...
- fonts loaded
- 2329 pixels (ratio 0.01 of all image pixels) are different.
- waiting 100ms before taking screenshot
- taking page screenshot
- disabled all CSS animations
- waiting for fonts to load...
- fonts loaded
- captured a stable screenshot
- 2329 pixels (ratio 0.01 of all image pixels) are different.
25 | await ionModalDidPresent.next();
26 |
> 27 | await expect(page).toHaveScreenshot(screenshot(`datetime-overlay-modal`));
| ^
28 | });
29 |
30 | test('should size the popover correctly', async ({ page, skip }) => {
at /ionic/src/components/datetime-button/test/overlays/datetime-button.e2e.ts:27:26
|
|
🎭 Playwright Run Summary
216 skipped
259 passed (2.3m)
|
|
🎭 Playwright Run Summary
534 passed (3.0m)
|
|
🎭 Playwright Run Summary
1 skipped
534 passed (3.1m)
|
|
🎭 Playwright Run Summary
1 skipped
537 passed (3.3m)
|
|
🎭 Playwright Run Summary
4 skipped
511 passed (3.4m)
|
|
🎭 Playwright Run Summary
212 skipped
313 passed (3.6m)
|
|
🎭 Playwright Run Summary
4 skipped
515 passed (3.7m)
|
|
🎭 Playwright Run Summary
648 passed (4.2m)
|
|
🎭 Playwright Run Summary
10 skipped
503 passed (4.9m)
|
|
🎭 Playwright Run Summary
14 skipped
401 passed (5.1m)
|
|
🎭 Playwright Run Summary
1 flaky
[Mobile Safari] › src/components/datetime-button/test/overlays/datetime-button.e2e.ts:11:9 › datetime-button: rendering - ios/ltr › should size the modal correctly
5 skipped
512 passed (5.2m)
|
|
🎭 Playwright Run Summary
1 skipped
538 passed (6.2m)
|
|
🎭 Playwright Run Summary
10 skipped
529 passed (6.7m)
|
|
🎭 Playwright Run Summary
4 skipped
537 passed (6.7m)
|
|
🎭 Playwright Run Summary
1 skipped
528 passed (6.8m)
|
|
🎭 Playwright Run Summary
5 skipped
573 passed (7.0m)
|
|
🎭 Playwright Run Summary
14 skipped
497 passed (7.0m)
|
|
🎭 Playwright Run Summary
2 skipped
517 passed (7.0m)
|
|
🎭 Playwright Run Summary
5 skipped
517 passed (7.2m)
|
|
🎭 Playwright Run Summary
7 skipped
510 passed (7.6m)
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
ionic-angular
|
667 KB |
sha256:6def6e2a82382cea38f479f8ad9e3f88bb2f9f977017c9e1c837f9ad407ec3e6
|
|
|
ionic-angular-server
|
8.55 KB |
sha256:4c66462a77f1fdda50316daed114c0a97b2af3657884b59d5cb65b65ffa65ef2
|
|
|
ionic-core
|
4.57 MB |
sha256:682f19992d91ab158dccc9eab10e75e3f6e33e34eca3fd7c59e52a56097c2c4b
|
|
|
ionic-react
|
211 KB |
sha256:15527e3f15634bc67d38d1a79e1399b2b947d5a3ffb1418d5674c59226ed2c3d
|
|
|
ionic-react-router
|
27.9 KB |
sha256:a0bfc0eacd1a32f4b47f3b9bfea63eb4394f6e4af3d7b49aa0d0ffcee805245c
|
|
|
ionic-vue
|
233 KB |
sha256:586cd059fc071182467a045d2c1fd5fe65835ce40749ee72f8edc743b78cd9b5
|
|
|
ionic-vue-router
|
17 KB |
sha256:6d3e7227eab180e5c8152e2dbcfabb15535eb1ca090adac2a638d8fad1299193
|
|
|
test-results-1-20
|
442 KB |
sha256:93e0472a9a08ec7dbed347d31b1c6b70490782859c953ada66991a6968cd1071
|
|
|
test-results-10-20
|
460 KB |
sha256:2a29923b1d9c25f6d6fc18391df9d79abdd714228a33f06bc43212877e525111
|
|
|
test-results-11-20
|
503 KB |
sha256:6beb926867f220f734b8aeef6ac10af83c229baa75645f9ca2a8648c46cb5c95
|
|
|
test-results-12-20
|
442 KB |
sha256:8e20fec952f0525567d8ac100867b55f8f126b22b54feebf494c2e3b810a92d5
|
|
|
test-results-13-20
|
450 KB |
sha256:937fea5c3006708cf4ba6e1ca9e9c2868a761c8d9df40106365cac3f0691bd7c
|
|
|
test-results-14-20
|
407 KB |
sha256:7576c3086cf872b51aaecb4272d71f9677189c34ab512cfb6b13b1841ad557dc
|
|
|
test-results-15-20
|
431 KB |
sha256:9fa1be2ad1dfe8900ae7df5eddc78e6e8237ef7b79d49d97d683ec73b48c43fd
|
|
|
test-results-16-20
|
1.4 MB |
sha256:93bd193b87de703c9edf33e606ebff31c18279c3e6750f7b21b73ddceb8cdc1c
|
|
|
test-results-17-20
|
530 KB |
sha256:2a72bf299bf658f5bfd324675ece4194f5bee22f6c9e2aace5960d9fbac66515
|
|
|
test-results-18-20
|
505 KB |
sha256:53a4464274d5ae61f596ea860f996c6cb1edc3aeb88355ead5f5fe8288856cf9
|
|
|
test-results-19-20
|
396 KB |
sha256:6fa83988e9838494da6548b2c467b5478ef964877ff9391a162c0f9b52e8f2a1
|
|
|
test-results-2-20
|
471 KB |
sha256:17d66b50a432a44acab0c1c556a9cd3b686cb987668c987e1fb7201701c920c0
|
|
|
test-results-20-20
|
360 KB |
sha256:8930336183201a3457b319b56c34d62505528e330ae77bdb10031376aafc861e
|
|
|
test-results-3-20
|
431 KB |
sha256:9cf157e85cb3f8326f5c716607359779fc908da5f788b85d318ac531b9071222
|
|
|
test-results-4-20
|
521 KB |
sha256:4d04a85691ab0f11cd38666bdd6c5459f22a2fb23591f01a2b3df226692813cc
|
|
|
test-results-5-20
|
456 KB |
sha256:4047541f62073e79635d33ef1bc7490920b292194fa0767feb49298eb0b6e866
|
|
|
test-results-6-20
|
446 KB |
sha256:beb454f0acaf9da8c086169a40ef22ad35964f1bd3ad93032ac31f37524bab05
|
|
|
test-results-7-20
|
352 KB |
sha256:b7cd726ffd22316538b203a6c496446845871a4c2e2424c7a848c7a95a69a5f1
|
|
|
test-results-8-20
|
431 KB |
sha256:8c8081c11a737fcb7c5681832f7d395e120e9a2399b3f600a307ed35b5927ca8
|
|
|
test-results-9-20
|
437 KB |
sha256:a402c9f0e3e855780571fd1348b354702e10b30d40620de642a17e15c3f874e6
|
|