Skip to content

Commit 003fa4c

Browse files
committed
test(toolbar): update slotted images to run outside dark palettes
1 parent eb6bd74 commit 003fa4c

File tree

1 file changed

+64
-58
lines changed

1 file changed

+64
-58
lines changed

core/src/components/toolbar/test/basic/toolbar.e2e.ts

Lines changed: 64 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -19,64 +19,6 @@ configs({ modes: ['ios', 'md', 'ionic-md'], palettes: ['light', 'dark'], directi
1919
const header = page.locator('ion-header');
2020
await expect(header).toHaveScreenshot(screenshot(`toolbar-basic-text-only`));
2121
});
22-
23-
test('should not have visual regressions with slotted svgs', async ({ page }) => {
24-
await page.setContent(
25-
`
26-
<ion-header>
27-
<ion-toolbar>
28-
<img src="/src/components/toolbar/test/image.svg" slot="start"/>
29-
<ion-title>Toolbar</ion-title>
30-
<ion-img src="/src/components/toolbar/test/image.svg" slot="end"/>
31-
</ion-toolbar>
32-
</ion-header>
33-
`,
34-
config
35-
);
36-
37-
const header = page.locator('ion-header');
38-
await expect(header).toHaveScreenshot(screenshot(`toolbar-basic-slotted-svgs`));
39-
});
40-
41-
test('should not have visual regressions with slotted images', async ({ page }) => {
42-
await page.setContent(
43-
`
44-
<ion-header>
45-
<ion-toolbar>
46-
<img src="https://picsum.photos/id/237/50/50" slot="start" />
47-
<ion-title>Image | Ion-Image</ion-title>
48-
<ion-img src="https://picsum.photos/id/237/50/50" slot="end"></ion-img>
49-
</ion-toolbar>
50-
</ion-header>
51-
`,
52-
config
53-
);
54-
55-
const header = page.locator('ion-header');
56-
await expect(header).toHaveScreenshot(screenshot(`toolbar-basic-slotted-images`));
57-
});
58-
59-
test('should not have visual regressions with nested slotted images', async ({ page }) => {
60-
await page.setContent(
61-
`
62-
<ion-header>
63-
<ion-toolbar>
64-
<div slot="start">
65-
<img src="https://picsum.photos/id/237/50/50" />
66-
</div>
67-
<ion-title>Image | Ion-Image</ion-title>
68-
<div slot="end">
69-
<ion-img src="https://picsum.photos/id/237/50/50"></ion-img>
70-
</div>
71-
</ion-toolbar>
72-
</ion-header>
73-
`,
74-
config
75-
);
76-
77-
const header = page.locator('ion-header');
78-
await expect(header).toHaveScreenshot(screenshot(`toolbar-basic-nested-slotted-images`));
79-
});
8022
});
8123
}
8224
);
@@ -238,3 +180,67 @@ configs({ modes: ['ios', 'md', 'ionic-md'], palettes: ['light', 'dark'] }).forEa
238180
});
239181
});
240182
});
183+
184+
configs({ modes: ['ios', 'md', 'ionic-md'], directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
185+
test.describe(title('toolbar: basic'), () => {
186+
test.describe(title('slot content'), () => {
187+
test('should not have visual regressions with slotted svgs', async ({ page }) => {
188+
await page.setContent(
189+
`
190+
<ion-header>
191+
<ion-toolbar>
192+
<img src="/src/components/toolbar/test/image.svg" slot="start"/>
193+
<ion-title>Toolbar</ion-title>
194+
<ion-img src="/src/components/toolbar/test/image.svg" slot="end"/>
195+
</ion-toolbar>
196+
</ion-header>
197+
`,
198+
config
199+
);
200+
201+
const header = page.locator('ion-header');
202+
await expect(header).toHaveScreenshot(screenshot(`toolbar-basic-slotted-svgs`));
203+
});
204+
205+
test('should not have visual regressions with slotted images', async ({ page }) => {
206+
await page.setContent(
207+
`
208+
<ion-header>
209+
<ion-toolbar>
210+
<img src="https://picsum.photos/id/237/50/50" slot="start" />
211+
<ion-title>Toolbar</ion-title>
212+
<ion-img src="https://picsum.photos/id/237/50/50" slot="end"></ion-img>
213+
</ion-toolbar>
214+
</ion-header>
215+
`,
216+
config
217+
);
218+
219+
const header = page.locator('ion-header');
220+
await expect(header).toHaveScreenshot(screenshot(`toolbar-basic-slotted-images`));
221+
});
222+
223+
test('should not have visual regressions with nested slotted images', async ({ page }) => {
224+
await page.setContent(
225+
`
226+
<ion-header>
227+
<ion-toolbar>
228+
<div slot="start">
229+
<img src="https://picsum.photos/id/237/50/50" />
230+
</div>
231+
<ion-title>Toolbar</ion-title>
232+
<div slot="end">
233+
<ion-img src="https://picsum.photos/id/237/50/50"></ion-img>
234+
</div>
235+
</ion-toolbar>
236+
</ion-header>
237+
`,
238+
config
239+
);
240+
241+
const header = page.locator('ion-header');
242+
await expect(header).toHaveScreenshot(screenshot(`toolbar-basic-nested-slotted-images`));
243+
});
244+
});
245+
});
246+
});

0 commit comments

Comments
 (0)