refactor(menu): move will-change

thetaPC · thetaPC · commit 0a626041fabc · 2024-11-21T11:43:33.000-08:00
diff --git a/core/src/components/menu/menu.scss b/core/src/components/menu/menu.scss
@@ -39,6 +39,8 @@
 .menu-inner {
   @include transform(translateX(-9999px));
 
+  will-change: transform;
+
   display: flex;
   position: absolute;
 
diff --git a/core/src/utils/menu-controller/animations/overlay.ts b/core/src/utils/menu-controller/animations/overlay.ts
@@ -27,7 +27,6 @@ export const menuOverlayAnimation = (menu: MenuI): Animation => {
     openedX = '0px';
   }
 
-  menu.menuInnerEl!.style.willChange = 'transform';
   menuAnimation.addElement(menu.menuInnerEl!).fromTo('transform', `translateX(${closedX})`, `translateX(${openedX})`);
 
   const mode = getIonMode(menu);

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,6 @@ export const menuOverlayAnimation = (menu: MenuI): Animation => {`
`27`	`27`	`openedX = '0px';`
`28`	`28`	`}`
`29`	`29`
`30`		`- menu.menuInnerEl!.style.willChange = 'transform';`
`31`	`30`	menuAnimation.addElement(menu.menuInnerEl!).fromTo('transform', `translateX(${closedX})`, `translateX(${openedX})`);
`32`	`31`
`33`	`32`	`const mode = getIonMode(menu);`