Skip to content

Commit 12b60de

Browse files
committed
fix(pickers): run lint
1 parent 98c1fa1 commit 12b60de

File tree

6 files changed

+17
-22
lines changed

6 files changed

+17
-22
lines changed

core/src/components/picker-column-option/test/a11y/picker-column-option.e2e.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ configs({ directions: ['ltr'] }).forEach(({ config, title }) => {
1212

1313
const results = await new AxeBuilder({ page }).analyze();
1414

15-
const hasKnownViolations = results.violations.filter(violation => violation.id === 'color-contrast');
16-
const violations = results.violations.filter(violation => !hasKnownViolations.includes(violation));
15+
const hasKnownViolations = results.violations.filter((violation) => violation.id === 'color-contrast');
16+
const violations = results.violations.filter((violation) => !hasKnownViolations.includes(violation));
1717

1818
if (hasKnownViolations.length > 0) {
1919
console.warn('Known color contrast violations:', hasKnownViolations);

core/src/components/picker/picker.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -410,7 +410,7 @@ export class Picker implements ComponentInterface {
410410
colEl: HTMLIonPickerColumnElement,
411411
value: string,
412412
zeroBehavior: 'start' | 'end' = 'start'
413-
): boolean => {
413+
): boolean => {
414414
if (!value) {
415415
return false;
416416
}
@@ -535,10 +535,7 @@ export class Picker implements ComponentInterface {
535535

536536
render() {
537537
return (
538-
<Host
539-
onPointerDown={(ev: PointerEvent) => this.onPointerDown(ev)}
540-
onClick={() => this.onClick()}
541-
>
538+
<Host onPointerDown={(ev: PointerEvent) => this.onPointerDown(ev)} onClick={() => this.onClick()}>
542539
<input
543540
aria-hidden="true"
544541
tabindex={-1}

core/src/components/picker/test/a11y/picker.e2e.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ configs().forEach(({ title, config }) => {
99

1010
const results = await new AxeBuilder({ page }).analyze();
1111

12-
const hasKnownViolations = results.violations.filter(violation => violation.id === 'color-contrast');
13-
const violations = results.violations.filter(violation => !hasKnownViolations.includes(violation));
12+
const hasKnownViolations = results.violations.filter((violation) => violation.id === 'color-contrast');
13+
const violations = results.violations.filter((violation) => !hasKnownViolations.includes(violation));
1414

1515
if (hasKnownViolations.length > 0) {
1616
console.warn('A11Y: Known violation - contrast color.', hasKnownViolations);

core/src/components/picker/test/basic/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ <h2>One Numeric Input</h2>
7070
<h2>Two Numeric Input</h2>
7171
<ion-picker>
7272
<ion-picker-column numeric-input="true" id="dual-numeric-first"></ion-picker-column>
73-
<ion-picker-column numeric-input="true" id="dual-numeric-second" ></ion-picker-column>
73+
<ion-picker-column numeric-input="true" id="dual-numeric-second"></ion-picker-column>
7474
</ion-picker>
7575
</div>
7676
<div class="grid-item">

core/src/components/picker/test/basic/picker.e2e.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,10 +109,9 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
109109
const firstColumn = await page.evaluate(() => document.querySelector('ion-picker-column#first'));
110110
const secondColumn = await page.evaluate(() => document.querySelector('ion-picker-column#second'));
111111

112-
113112
// Focus first column
114113
await page.keyboard.press('Tab');
115-
114+
116115
let activeElement = await page.evaluate(() => document.activeElement);
117116
expect(activeElement).toEqual(firstColumn);
118117

core/src/components/picker/test/keyboard-entry/picker.e2e.ts

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -35,21 +35,20 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
3535
</script>
3636
`,
3737
config
38-
);
39-
38+
);
39+
4040
const column = page.locator('ion-picker-column');
41-
41+
4242
const colShadowRoot = await column.evaluateHandle((el) => el.shadowRoot);
4343
const columnPickerOpts = await colShadowRoot.evaluateHandle((root) => root?.querySelector('.picker-opts'));
44-
44+
4545
const ionChange = await page.spyOnEvent('ionChange');
4646
await columnPickerOpts.evaluate((el) => el && (el as HTMLElement).focus());
47-
47+
4848
await page.keyboard.press('Digit2');
49-
49+
5050
await expect(ionChange).toHaveReceivedEventDetail({ value: 2 });
5151
await expect(column).toHaveJSProperty('value', 2);
52-
5352
});
5453

5554
test('should scroll to and update the value prop for multiple columns', async ({ page }) => {
@@ -109,15 +108,15 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
109108

110109
const firstColShadowRoot = await firstColumn.evaluateHandle((el) => el.shadowRoot);
111110
const columnPickerOpts = await firstColShadowRoot.evaluateHandle((root) => root?.querySelector('.picker-opts'));
112-
111+
113112
// Focus first column
114113
await columnPickerOpts.evaluate((el) => el && (el as HTMLElement).focus());
115114

116115
await page.keyboard.press('Digit2');
117116

118117
await expect(firstIonChange).toHaveReceivedEventDetail({ value: 2 });
119118
await expect(firstColumn).toHaveJSProperty('value', 2);
120-
119+
121120
// Focus second column
122121
await page.keyboard.press('Tab');
123122

@@ -165,7 +164,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
165164

166165
const colShadowRoot = await column.evaluateHandle((el) => el.shadowRoot);
167166
const columnPickerOpts = await colShadowRoot.evaluateHandle((root) => root?.querySelector('.picker-opts'));
168-
167+
169168
const ionChange = await page.spyOnEvent('ionChange');
170169
await columnPickerOpts.evaluate((el) => el && (el as HTMLElement).focus());
171170

0 commit comments

Comments
 (0)