Skip to content

Commit 93cca29

Browse files
committed
chore(react-router): clean up
1 parent 4bc580c commit 93cca29

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

packages/react-router/src/ReactRouter/StackManager.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,8 +207,6 @@ export class StackManager extends React.PureComponent<StackManagerProps> {
207207
}
208208

209209
if (routeInfo.routeAction === 'replace') {
210-
// For replace actions, decide whether to unmount the leaving view.
211-
// The key question is: are these routes in the same navigation context?
212210
const enteringRoutePath = enteringViewItem?.reactElement?.props?.path as string | undefined;
213211
const leavingRoutePath = leavingViewItem?.reactElement?.props?.path as string | undefined;
214212

packages/react-router/test/base/tests/e2e/specs/content-change-navigation.cy.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
/**
22
* Verifies that when view content changes (causing IonPage to remount)
33
* while navigation is happening, the correct view is displayed.
4+
*
5+
* @see https://github.com/ionic-team/ionic-framework/issues/28878
46
*/
57

68
const port = 3000;
79

8-
describe('Content Change Navigation Tests (Issue #28878)', () => {
10+
describe('Content Change Navigation Tests', () => {
911
it('should navigate to list page correctly', () => {
1012
cy.visit(`http://localhost:${port}/content-change-navigation`);
1113
cy.ionPageVisible('content-nav-home');

0 commit comments

Comments
 (0)