Skip to content

Commit ec9251d

Browse files
committed
refactor(select): use gray for no fill and in item
1 parent bb14c4f commit ec9251d

File tree

6 files changed

+12
-18
lines changed

6 files changed

+12
-18
lines changed

core/src/components/select/select.md.outline.scss

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -245,15 +245,13 @@
245245
// ----------------------------------------------------------------
246246

247247
/**
248-
* When the select has a fill, is
249-
* in an item, and is expanded or focused,
250-
* then the icon should take on the
251-
* highlight color.
248+
* When the select has no fill and
249+
* in an item, then the icon should
250+
* take on the highlight color.
252251
*/
253252
:host(.in-item.select-expanded.select-fill-outline) .select-wrapper .select-icon,
254-
:host(.in-item.select-expanded.ion-touched.ion-invalid.select-fill-outline) .select-wrapper .select-icon,
255253
:host(.in-item.has-focus.select-fill-outline) .select-wrapper .select-icon,
256254
:host(.in-item.has-focus.ion-valid.select-fill-outline) .select-wrapper .select-icon,
257-
:host(.in-item.has-focus.ion-touched.ion-invalid.select-fill-outline) .select-wrapper .select-icon {
255+
:host(.in-item.ion-touched.ion-invalid.select-fill-outline) .select-wrapper .select-icon {
258256
color: var(--highlight-color);
259257
}

core/src/components/select/select.md.scss

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -87,16 +87,14 @@
8787
}
8888

8989
/**
90-
* When the select has no fill, is
91-
* in an item, and is expanded or focused,
92-
* then the icon should be the same color
93-
* as the text color.
90+
* When the select has no fill and
91+
* in an item, then the icon should
92+
* be the same color as the text color.
9493
*/
9594
:host(.in-item.select-expanded) .select-wrapper .select-icon,
96-
:host(.in-item.select-expanded.ion-touched.ion-invalid) .select-wrapper .select-icon,
9795
:host(.in-item.has-focus) .select-wrapper .select-icon,
9896
:host(.in-item.has-focus.ion-valid) .select-wrapper .select-icon,
99-
:host(.in-item.has-focus.ion-touched.ion-invalid) .select-wrapper .select-icon {
97+
:host(.in-item.ion-touched.ion-invalid) .select-wrapper .select-icon {
10098
color: #{$select-md-icon-color};
10199
}
102100

core/src/components/select/select.md.solid.scss

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -85,15 +85,13 @@
8585
// ----------------------------------------------------------------
8686

8787
/**
88-
* When the select has a fill, is
89-
* in an item, and is expanded or focused,
90-
* then the icon should take on the
91-
* highlight color.
88+
* When the select has no fill and
89+
* in an item, then the icon should
90+
* take on the highlight color.
9291
*/
9392
:host(.in-item.select-expanded.select-fill-solid) .select-wrapper .select-icon,
94-
:host(.in-item.select-expanded.ion-touched.ion-invalid.select-fill-solid) .select-wrapper .select-icon,
9593
:host(.in-item.has-focus.select-fill-solid) .select-wrapper .select-icon,
9694
:host(.in-item.has-focus.ion-valid.select-fill-solid) .select-wrapper .select-icon,
97-
:host(.in-item.has-focus.ion-touched.ion-invalid.select-fill-solid) .select-wrapper .select-icon {
95+
:host(.in-item.ion-touched.ion-invalid.select-fill-solid) .select-wrapper .select-icon {
9896
color: var(--highlight-color);
9997
}
-19 Bytes
Loading
-47 Bytes
Loading
-6 Bytes
Loading

0 commit comments

Comments
 (0)