Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.11.0: missing RID method #654

Open
tomsun opened this issue Mar 30, 2022 · 1 comment
Open

v1.11.0: missing RID method #654

tomsun opened this issue Mar 30, 2022 · 1 comment

Comments

@tomsun
Copy link

tomsun commented Mar 30, 2022

Your environment.

  • Version:v1.11.0 (latest)

What happened?

When upgrading my setup to use ion-sfu v1.11.0 I get missing RID method at build time.

@Sean-Der seems to fix this 7 commits ahead of v.1.11.0, in 53cf929ff5f11241ed83cd1e2400c91370021439, but there is no tagged release yet that includes this fix.

# github.com/pion/ion-sfu/pkg/sfu
79/go/pkg/mod/github.com/pion/[email protected]/pkg/sfu/publisher.go:380:52: cannot use downTrack (type *DownTrack) as type webrtc.TrackLocal in argument to rp.AddTrack:
80	*DownTrack does not implement webrtc.TrackLocal (missing RID method)
81/go/pkg/mod/github.com/pion/[email protected]/pkg/sfu/publisher.go:428:18: impossible type assertion:
82	*DownTrack does not implement webrtc.TrackLocal (missing RID method)
83/go/pkg/mod/github.com/pion/[email protected]/pkg/sfu/relaypeer.go:137:52: cannot use downTrack (type *DownTrack) as type webrtc.TrackLocal in argument to rp.AddTrack:
84	*DownTrack does not implement webrtc.TrackLocal (missing RID method)
85/go/pkg/mod/github.com/pion/[email protected]/pkg/sfu/relaypeer.go:184:18: impossible type assertion:
86	*DownTrack does not implement webrtc.TrackLocal (missing RID method)
87/go/pkg/mod/github.com/pion/[email protected]/pkg/sfu/router.go:240:64: cannot use downTrack (type *DownTrack) as type webrtc.TrackLocal in argument to sub.pc.AddTransceiverFromTrack:
88	*DownTrack does not implement webrtc.TrackLocal (missing RID method)
@OrlandoCo
Copy link
Collaborator

@tomsun mm looks like the interface for TrackLocal changed, is a quick fix just required to create the RID method on Downtrack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants