Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 24, 2025

Description of change

Decision made to keep TransactionDigest and BlockDigest as separate structures rather than merging them.

The comment suggested potentially joining the two digest types since they share the same parameters. After evaluation, keeping them separate was deemed the better approach.

Links to any relevant issues

Closes #8220

How the change has been tested

  • Basic tests (linting, compilation, formatting, unit/integration tests)
  • Patch-specific tests (correctness, functionality coverage)
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
Original prompt

This section details on the original issue you should resolve

<issue_title>Join TransactionDigest with BlockDigest</issue_title>
<issue_description>We might need to join TransactionDigest with BlockDigest since we use the same parameters for both structures. TransactionDigest is used for including a commitment for a transaction data to a block header. This digest is used for BlockDigest computations of BlockHeader does not include explicitly the transaction data. </issue_description>

<agent_instructions>Let's keep it separate. We need to remove the TODO and a comment.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@piotrm50 Let's keep it separate. We need to remove the TODO and a comment.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@vercel
Copy link

vercel bot commented Nov 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

6 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
apps-backend Ignored Ignored Preview Nov 24, 2025 10:19am
apps-ui-kit Ignored Ignored Preview Nov 24, 2025 10:19am
iota-evm-bridge Ignored Ignored Preview Nov 24, 2025 10:19am
iota-multisig-toolkit Ignored Ignored Preview Nov 24, 2025 10:19am
rebased-explorer Ignored Ignored Preview Nov 24, 2025 10:19am
wallet-dashboard Ignored Ignored Preview Nov 24, 2025 10:19am

@vercel vercel bot temporarily deployed to Preview – iota-multisig-toolkit November 24, 2025 09:58 Inactive
@vercel vercel bot temporarily deployed to Preview – rebased-explorer November 24, 2025 09:58 Inactive
@vercel vercel bot temporarily deployed to Preview – apps-ui-kit November 24, 2025 09:58 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-dashboard November 24, 2025 09:58 Inactive
@vercel vercel bot temporarily deployed to Preview – apps-backend November 24, 2025 09:58 Inactive
@vercel vercel bot temporarily deployed to Preview – iota-evm-bridge November 24, 2025 09:58 Inactive
Copilot AI changed the title [WIP] Join TransactionDigest with BlockDigest for consistency Remove TODO comment about joining TransactionDigest with BlockDigest Nov 24, 2025
Copilot AI requested a review from piotrm50 November 24, 2025 10:20
Copilot finished work on behalf of piotrm50 November 24, 2025 10:20
@piotrm50 piotrm50 added the consensus Issues related to the Core Consensus team label Nov 24, 2025
@piotrm50 piotrm50 changed the title Remove TODO comment about joining TransactionDigest with BlockDigest chore(starfish): Remove TODO comment about joining TransactionDigest with BlockDigest Nov 24, 2025
@piotrm50 piotrm50 marked this pull request as ready for review November 24, 2025 12:45
@piotrm50 piotrm50 requested a review from a team as a code owner November 24, 2025 12:45
@alexsporn alexsporn merged commit c45a160 into develop Nov 27, 2025
81 of 85 checks passed
@alexsporn alexsporn deleted the copilot/join-transaction-and-block-digest branch November 27, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consensus Issues related to the Core Consensus team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Join TransactionDigest with BlockDigest

4 participants