Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pubsub deprecated in ipfs > 0.20.0 #322

Open
kasteph opened this issue May 17, 2023 · 3 comments
Open

chore: pubsub deprecated in ipfs > 0.20.0 #322

kasteph opened this issue May 17, 2023 · 3 comments

Comments

@kasteph
Copy link
Collaborator

kasteph commented May 17, 2023

failing test

pubsub command will be deprecated in the next release: rel notes v0.19.0.

We can either remove this entirely or have it be supported for lower versions.

@crushr3sist
Copy link
Contributor

I believe if the actual Kubo IPFS doesn't support the pub-sub command it should be removed from the client as we already have a lot of version-related issues.

It would be more efficient to just remove the functionality.

I'll begin removing the pub-sub code from the client lib to restrict users from causing an error in their code from the usage of pub-sub.

@kasteph
Copy link
Collaborator Author

kasteph commented May 17, 2023

@Wizock that sounds good to me, I would also rather remove it entirely from the client. Thanks a lot and appreciate you picking this up!

@kasteph kasteph changed the title chore: pubsub deprecated in ipfs >= 0.19.0 chore: pubsub deprecated in ipfs >= 0.20.0 May 17, 2023
@kasteph kasteph changed the title chore: pubsub deprecated in ipfs >= 0.20.0 chore: pubsub deprecated in ipfs > 0.20.0 May 17, 2023
@crushr3sist
Copy link
Contributor

@kasteph I removed the pubsub tests in #326 :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants