From 4715a5458c4b02eecb7290a8961a9f1321ac2ff8 Mon Sep 17 00:00:00 2001 From: Henrique Dias Date: Tue, 9 Apr 2024 15:54:52 +0200 Subject: [PATCH] feedback --- CHANGELOG.md | 2 +- gateway/remote_blocks_backend.go | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 24d8f7d4d..f2b810bac 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,7 +16,7 @@ The following emojis are used to highlight certain changes: ### Added -* `gateway` now includes `NewRemoteBlocksBackend` which allows you to create a gateway backend that uses one or multiple other gateways as backend. These gateways must support RAW block requests, as well as IPNS Record requests. With this, we also introduced a `NewCacheBlockStore`, `NewRemoteBlockstore` and `NewRemoteValueStore`. +* `gateway` now includes `NewRemoteBlocksBackend` which allows you to create a gateway backend that uses one or multiple other gateways as backend. These gateways must support RAW block requests (`application/vnd.ipld.raw`), as well as IPNS Record requests (`application/vnd.ipfs.ipns-record`). With this, we also introduced a `NewCacheBlockStore`, `NewRemoteBlockstore` and `NewRemoteValueStore`. ### Changed diff --git a/gateway/remote_blocks_backend.go b/gateway/remote_blocks_backend.go index 5a9f90ead..5b96385d8 100644 --- a/gateway/remote_blocks_backend.go +++ b/gateway/remote_blocks_backend.go @@ -9,6 +9,7 @@ import ( "go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp" ) +// TODO: make this configurable via BlocksBackendOption const getBlockTimeout = time.Second * 60 // NewRemoteBlocksBackend creates a new [BlocksBackend] instance backed by one