Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitswap/httpnet: add WithDenylist option #861

Open
lidel opened this issue Feb 28, 2025 · 0 comments
Open

bitswap/httpnet: add WithDenylist option #861

lidel opened this issue Feb 28, 2025 · 0 comments
Labels
need/triage Needs initial labeling and prioritization topic/bitswap

Comments

@lidel
Copy link
Member

lidel commented Feb 28, 2025

We have ability to enable HTTP retrieval for specific hostnames (only do HTTP with hosts from allowlist) via httpnet.WithAllowlist

To prepare for the future where we enable this by default in places like Kubo, there should be a companion, opposite flag that allows us to pass explicit denylist (with known hosts that should NOT be used for HTTP retrieval) – httpnet.WithDenylist

The denylist should apply to both original URL and any HTTP redirects.

The main reason here is to avoid situation where defunct gateways start returning redirects to ipfs.io and dweb.link, effectively acting as amplification vector (note: there may be a better fix in #862).

cc @hsanjuan

@lidel lidel added need/triage Needs initial labeling and prioritization topic/bitswap labels Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization topic/bitswap
Projects
None yet
Development

No branches or pull requests

1 participant