Simplify fetcher setup #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default fetcher already uses the same Reifier that we were setting explicitally (https://github.com/ipfs/boxo/blob/main/fetcher/impl/blockservice/fetcher.go#L127).
hacdias
reviewed
Oct 13, 2023
Co-authored-by: Henrique Dias <[email protected]>
|
Ok, I got confused. We need to add dagpb support on top of the default PrototypeChooser using dagpb.AddSupportToChooser. But yeah given the default is already defined we can just use it rather than rewriting it. |
Codecov Report
@@ Coverage Diff @@
## main #485 +/- ##
==========================================
+ Coverage 65.15% 65.75% +0.59%
==========================================
Files 204 207 +3
Lines 25112 25135 +23
==========================================
+ Hits 16362 16527 +165
+ Misses 7273 7149 -124
+ Partials 1477 1459 -18
|
hacdias
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default fetcher already uses the same PrototypeChooser that we were setting explicitally (https://github.com/ipfs/boxo/blob/main/fetcher/impl/blockservice/fetcher.go#L127).