Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bitswap/client/providerquerymanager): don't end trace span until … #725

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

gammazero
Copy link
Contributor

@gammazero gammazero commented Nov 20, 2024

…all providers are returned

cherry picked from #641

…all providers are returned

(cherry picked from commit 12cbf25)
@gammazero gammazero requested a review from a team as a code owner November 20, 2024 21:53
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.41%. Comparing base (138b596) to head (837fd32).
Report is 1 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #725      +/-   ##
==========================================
+ Coverage   60.29%   60.41%   +0.11%     
==========================================
  Files         243      243              
  Lines       31057    31059       +2     
==========================================
+ Hits        18727    18763      +36     
+ Misses      10659    10632      -27     
+ Partials     1671     1664       -7     
Files with missing lines Coverage Δ
...ernal/providerquerymanager/providerquerymanager.go 90.56% <100.00%> (+0.83%) ⬆️

... and 11 files with indirect coverage changes


🚨 Try these New Features:

@gammazero
Copy link
Contributor Author

We can merge this now or wait for #641 to merge

Copy link
Contributor

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this way we don't have to wait on the other PR to get better tracing results

@gammazero gammazero merged commit c91cc1d into main Nov 21, 2024
16 checks passed
@gammazero gammazero deleted the trace-fix-from-641 branch November 21, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants