Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for Query.ReturnSizes #5

Open
MichaelMure opened this issue Nov 22, 2019 · 2 comments
Open

support for Query.ReturnSizes #5

MichaelMure opened this issue Nov 22, 2019 · 2 comments

Comments

@MichaelMure
Copy link

In ipfs/go-datastore#134 is added a new request field in queries: Query.ReturnSizes.

To honor this field, datastore implementations can either:

  • return the size of the entry in Entry.Size if Query.ReturnSizes is set, or -1 otherwise
  • consider that returning the size doesn't imply a performance cost and always return the size in Entry.Size
@hsanjuan
Copy link
Contributor

hsanjuan commented Mar 6, 2020

Hey @MichaelMure , do you use this datastore?

I guess you probably don't want to contribute a fix for this at this point, but if you (or anyone does), I'll try to review and push it out swiftly.

@MichaelMure
Copy link
Author

I'm not using it, I filed this issue for the sake of completion of ipfs/go-datastore#134

Thanks for asking :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants