Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker : Fix Dockerfile inspired by Kubo official Dockerfile #291

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FournyP
Copy link

@FournyP FournyP commented May 1, 2024

Hi,

I've done this little change in the Dockerfile on my side for a personal project.

The build is clearly inspired by the official Kubo Dockerfile.
Imo it's make more sense than the older one.

It also bring the flexibility of the Kubo Dockerfile.

And the jq depency is downloaded in another FROM for paralleling purpose (as Kubo Dockerfile do in the utilities FROM).

image
image

Errors on the screen are because I didn't map the ports

Have a nice day

Copy link

welcome bot commented May 1, 2024

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@lidel
Copy link
Member

lidel commented Aug 27, 2024

Triage notes:

  • We will revisit this after Kubo 0.30 ships (Release 0.30 kubo#10436), making sure things run smoothly with the latest version

WORKDIR $SRC_DIR

# Install the plugin and build ipfs
RUN git clone --branch v0.28.0 https://github.com/ipfs/kubo.git .
Copy link
Member

@lidel lidel Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • TODO: switch to Kubo 0.33 once it ships


# The actual IPFS image we will use
FROM ipfs/kubo:v0.23.0
FROM ipfs/kubo:v0.28.0
Copy link
Member

@lidel lidel Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Kubo 0.33 once it ships

@lidel lidel added the status/blocked Unable to be worked further until needs are met label Sep 3, 2024
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FournyP do you mind switching to Kubo 0.30 and confirming things work as expected?

@lidel lidel added need/author-input Needs input from the original author and removed status/blocked Unable to be worked further until needs are met labels Sep 17, 2024
@lidel lidel marked this pull request as draft October 1, 2024 16:29
@@ -1,32 +1,39 @@
FROM golang:1.21-bookworm AS builder
FROM --platform=${BUILDPLATFORM:-linux/amd64} golang:1.22 AS builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FROM --platform=${BUILDPLATFORM:-linux/amd64} golang:1.22 AS builder
FROM --platform=${BUILDPLATFORM:-linux/amd64} golang:1.23 AS builder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/author-input Needs input from the original author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants