-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker : Fix Dockerfile inspired by Kubo official Dockerfile #291
base: master
Are you sure you want to change the base?
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
Triage notes:
|
WORKDIR $SRC_DIR | ||
|
||
# Install the plugin and build ipfs | ||
RUN git clone --branch v0.28.0 https://github.com/ipfs/kubo.git . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- TODO: switch to Kubo 0.33 once it ships
|
||
# The actual IPFS image we will use | ||
FROM ipfs/kubo:v0.23.0 | ||
FROM ipfs/kubo:v0.28.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Kubo 0.33 once it ships
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FournyP do you mind switching to Kubo 0.30 and confirming things work as expected?
@@ -1,32 +1,39 @@ | |||
FROM golang:1.21-bookworm AS builder | |||
FROM --platform=${BUILDPLATFORM:-linux/amd64} golang:1.22 AS builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FROM --platform=${BUILDPLATFORM:-linux/amd64} golang:1.22 AS builder | |
FROM --platform=${BUILDPLATFORM:-linux/amd64} golang:1.23 AS builder |
Hi,
I've done this little change in the Dockerfile on my side for a personal project.
The build is clearly inspired by the official Kubo Dockerfile.
Imo it's make more sense than the older one.
It also bring the flexibility of the Kubo Dockerfile.
And the jq depency is downloaded in another FROM for paralleling purpose (as Kubo Dockerfile do in the
utilities
FROM).Errors on the screen are because I didn't map the ports
Have a nice day