integer number in json but dump into cbor the number is float

[atenjin]

testcase in the code:

go-ipld-cbor/node_test.go

Line 337 in e249008

func TestResolvedValIsJsonable(t *testing.T) {

func TestResolvedValIsJsonable(t *testing.T) {
        // we can see that the value in map "foo" for key "bar" and "baz" is **interger**
	data := `{
		"foo": {
			"bar": 1,
			"baz": 2
		}
	}`
	n, err := FromJSON(strings.NewReader(data), mh.SHA2_256, -1)
	if err != nil {
		t.Fatal(err)
	}
        // ...
}

but in function FromJSON

func FromJSON(r io.Reader, mhType uint64, mhLen int) (*Node, error) {
	var m interface{}
        // receive the preview str, it would result be like
        // map { "bar" => 1 (float64) ; "baz" => 2 (float64) }
	err := json.NewDecoder(r).Decode(&m)  
	if err != nil {
		return nil, err
	}
        // and then, cbor would use float64 to serialize, but in fact, this value is an integer
	obj, err := convertToCborIshObj(m)
	if err != nil {
		return nil, err
	}

	return WrapObject(obj, mhType, mhLen)
}

I think this is a wrong case. Please check it, thanks.

[hsanjuan]

The wikipedia says that The format makes no distinction between integer and floating-point (https://en.wikipedia.org/wiki/JSON#Data_types_and_syntax). The Go decoder chooses to default to float64. So I think you can say that even though those look like integers, they are actually floating point numbers.

Does this represent an issue for you?