Skip to content

Commit

Permalink
typing lint now that we require 3.9
Browse files Browse the repository at this point in the history
  • Loading branch information
minrk committed Oct 25, 2024
1 parent e9555d4 commit e31ff22
Show file tree
Hide file tree
Showing 7 changed files with 14 additions and 17 deletions.
8 changes: 4 additions & 4 deletions docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import os
import shutil
from pathlib import Path
from typing import Any, Dict, List
from typing import Any

# If extensions (or modules to document with autodoc) are in another directory,
# add these directories to sys.path here. If the directory is relative to the
Expand Down Expand Up @@ -70,7 +70,7 @@
# built documents.
#

version_ns: Dict[str, Any] = {}
version_ns: dict[str, Any] = {}
here = Path(__file__).parent.resolve()
version_py = Path(here) / os.pardir / "ipykernel" / "_version.py"
with open(version_py) as f:
Expand Down Expand Up @@ -159,7 +159,7 @@
# Add any paths that contain custom static files (such as style sheets) here,
# relative to this directory. They are copied after the builtin static files,
# so a file named "default.css" will overwrite the builtin "default.css".
html_static_path: List[str] = []
html_static_path: list[str] = []

# Add any extra paths that contain custom files (such as robots.txt or
# .htaccess) here, relative to this directory. These files are copied
Expand Down Expand Up @@ -226,7 +226,7 @@

# -- Options for LaTeX output ---------------------------------------------

latex_elements: Dict[str, object] = {}
latex_elements: dict[str, object] = {}

# Grouping the document tree into LaTeX files. List of tuples
# (source start file, target name, title,
Expand Down
3 changes: 1 addition & 2 deletions ipykernel/_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
store the current version info of the server.
"""
import re
from typing import List

# Version string must appear intact for hatch versioning
__version__ = "7.0.0a0"
Expand All @@ -11,7 +10,7 @@
pattern = r"(?P<major>\d+).(?P<minor>\d+).(?P<patch>\d+)(?P<rest>.*)"
match = re.match(pattern, __version__)
assert match is not None
parts: List[object] = [int(match[part]) for part in ["major", "minor", "patch"]]
parts: list[object] = [int(match[part]) for part in ["major", "minor", "patch"]]
if match["rest"]:
parts.append(match["rest"])
version_info = tuple(parts)
Expand Down
2 changes: 1 addition & 1 deletion ipykernel/debugger.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def _reset_tcp_pos(self):

def _put_message(self, raw_msg):
self.log.debug("QUEUE - _put_message:")
msg = t.cast(t.Dict[str, t.Any], jsonapi.loads(raw_msg))
msg = t.cast(dict[str, t.Any], jsonapi.loads(raw_msg))
if msg["type"] == "event":
self.log.debug("QUEUE - received event:")
self.log.debug(msg)
Expand Down
4 changes: 1 addition & 3 deletions ipykernel/inprocess/channels.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
# Copyright (c) IPython Development Team.
# Distributed under the terms of the Modified BSD License.

from typing import List

from jupyter_client.channelsabc import HBChannelABC

# -----------------------------------------------------------------------------
Expand All @@ -15,7 +13,7 @@
class InProcessChannel:
"""Base class for in-process channels."""

proxy_methods: List[object] = []
proxy_methods: list[object] = []

def __init__(self, client=None):
"""Initialize the channel."""
Expand Down
8 changes: 4 additions & 4 deletions ipykernel/iostream.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
from collections import defaultdict, deque
from io import StringIO, TextIOBase
from threading import Event, Thread, local
from typing import Any, Callable, Deque, Dict, Optional
from typing import Any, Callable, Optional

import zmq
from anyio import create_task_group, run, sleep, to_thread
Expand Down Expand Up @@ -94,8 +94,8 @@ def __init__(self, socket, pipe=False):
if pipe:
self._setup_pipe_in()
self._local = threading.local()
self._events: Deque[Callable[..., Any]] = deque()
self._event_pipes: Dict[threading.Thread, Any] = {}
self._events: deque[Callable[..., Any]] = deque()
self._event_pipes: dict[threading.Thread, Any] = {}
self._event_pipe_gc_lock: threading.Lock = threading.Lock()
self._event_pipe_gc_seconds: float = 10
self._setup_event_pipe()
Expand Down Expand Up @@ -470,7 +470,7 @@ def __init__(
self.pub_thread = pub_thread
self.name = name
self.topic = b"stream." + name.encode()
self._parent_header: contextvars.ContextVar[Dict[str, Any]] = contextvars.ContextVar(
self._parent_header: contextvars.ContextVar[dict[str, Any]] = contextvars.ContextVar(
"parent_header"
)
self._parent_header.set({})
Expand Down
4 changes: 2 additions & 2 deletions ipykernel/pickleutil.py
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ def __init__(self, f):
"""Initialize the can"""
self._check_type(f)
self.code = f.__code__
self.defaults: typing.Optional[typing.List[typing.Any]]
self.defaults: typing.Optional[list[typing.Any]]
if f.__defaults__:
self.defaults = [can(fd) for fd in f.__defaults__]
else:
Expand Down Expand Up @@ -475,7 +475,7 @@ def uncan_sequence(obj, g=None):
if buffer is not memoryview:
can_map[buffer] = CannedBuffer

uncan_map: typing.Dict[type, typing.Any] = {
uncan_map: dict[type, typing.Any] = {
CannedObject: lambda obj, g: obj.get_object(g),
dict: uncan_dict,
}
Expand Down
2 changes: 1 addition & 1 deletion ipykernel/thread.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def __init__(self, **kwargs):
self.pydev_do_not_trace = True
self.is_pydev_daemon_thread = True
self.__stop = Event()
self._tasks_and_args: t.List[t.Tuple[t.Any, t.Any]] = []
self._tasks_and_args: list[tuple[t.Any, t.Any]] = []

def add_task(self, task: t.Any, *args: t.Any) -> None:
# May only add tasks before the thread is started.
Expand Down

0 comments on commit e31ff22

Please sign in to comment.