-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
State can be shared cross different websockets #157
Comments
@ctomc I think we need to check and fix this one also iris-router/src/main/java/org/iris_events/router/model/UserSession.java Lines 97 to 105 in bf37b38
Once this is called, null is returned iris-router/src/main/java/org/iris_events/router/model/UserSession.java Lines 110 to 114 in bf37b38
So I guess we have to pass the session ID here iris-router/src/main/java/org/iris_events/router/ws/SocketV1.java Lines 120 to 125 in bf37b38
|
You are correct, that needs fixing |
This implementation can cause issues and inconsistency. As
ServerEndpointConfig
is shared across different WebSockets.It can happen that 2 WebSockets/Sessions will have the same ID
iris-router/src/main/java/org/iris_events/router/ws/WsContainerConfigurator.java
Lines 19 to 25 in 459b8e2
This issue is propagated forward here using EndpointConfig, which is also shared across the requests
iris-router/src/main/java/org/iris_events/router/ws/SocketV1.java
Lines 96 to 100 in 459b8e2
The text was updated successfully, but these errors were encountered: