Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve HTTP server logging #35

Open
samrushing opened this issue Sep 12, 2012 · 0 comments
Open

Improve HTTP server logging #35

samrushing opened this issue Sep 12, 2012 · 0 comments
Assignees

Comments

@samrushing
Copy link
Member

The (new) HTTP server needs some improvements to how it logs. It needs to concentrate all logging into the request.done() method, and ensure that it is always called. Currently, there are sprinklings of log calls in several places, probably because of the error exit path. [for example, a connection reset will cause an exception in request.error() that keeps done() from ever being called]. This also means the format of the log line is unreliable and no information about bytes transferred is available on connections that have errors.

@ghost ghost assigned samrushing Sep 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant