support for s2n, plus an http/2 implementation. #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the semantics around non-blocking I/O are very confusing.
and clean up the s2n_Extension.
don't send "howdy", this allows testing between coro++, blocking-mode s2n, and shrapnel.
Written to be separate from the NPN support so that NPN can be easily removed. [tested on server side, but not client side yet].
negotiate loop is in cys2n. implement writev.
close, shutdown: handle closed sockets gracefully.
place constants into namespace classes. read_frames: catch OSError. send_thread: catch OSError. send_goaway: new fun. frame_priority: new.
frame_settings: do you even iterate, bro? push_settings: allow override of initial settings via class var. run: push_settings at connect time (safari insists).
remove more spdy-related cruft.
To show off shrapnel's source code tree.
ERROR,FRAME,SETTINGS,FLAGS: use namespaces for protocol constants.
LOG/DEBUG: commented-out debug stuff reformatted.
h2_file: simplified, removed some cruft.
h2_server_request:
push headers opportunistically.
set server and date headers.
h2_protocol: moved code from h2_connection here.
h2_connection: handle_headers.
h2_client_request:
don't bother deriving from http_client.request.
use two latches: http design can't work here because the
entire connection is not devoted to sending reply content.
add :authority header.
frame_data: overridden to retire inflight sem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for mingling h2 and s2n in the same branch, unfortunately I needed a way to test the new ALPN support (which is also added to openssl.pyx), and I thought a 'quick' upgrade of spdy to h2 would do the trick. [no, it was not quick].
The hpack implementation is from https://github.com/samrushing/hpack, the intent is to rewrite it in Cython once it has stabilized.
Note: alpn in s2n is broken for now, waiting on aws/s2n-tls#182, so if you need to specifically test s2n+h2, you'll need to apply that patch to it.