Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkey is hardcoded #184

Open
Jaxlyfe opened this issue Feb 27, 2023 · 4 comments
Open

Hotkey is hardcoded #184

Jaxlyfe opened this issue Feb 27, 2023 · 4 comments

Comments

@Jaxlyfe
Copy link

Jaxlyfe commented Feb 27, 2023

Due to B for backpack, I wanted to change the binding to something I wont accidentally hit every 5 seconds when building.
But when changing the key bindings they show as conflicting, and will work for the duration of that session, but after relogging they will no longer work. Changing them via the config file provides the same issue.

This really feels like the key bindings are hard coded to BBOR.

MC : 1.19.2
Forge : 43.2.4
BBOR : 2.5.1 (2.6 provided the same issue)

@brianfreud
Copy link

I'm running into the same issue. If I change it, the hotkey shows and responds as the new key, but on game restart, while the hotkey still shows the new key, it goes back to using "b" as the actual hotkey. It also seems to block propogation of that key, as the backpack doesn't still also open.

@brianfreud
Copy link

I'm no expert, but it appears as though you're re-registering the hotkey every time the mod gets loaded (ie, client restart), which is why it's ignoring remappings through client config.

Key mainKey = KeyListener.register("bbor.key.toggleActive", "key.keyboard.b")

@DrCryllus
Copy link

Can confirm bug. Very irritating.

@MoonliteDelight
Copy link

Bumping issue because it's still a thing and seems to be across versions (i'm seeing it on 1.18.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants