Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Identical enemy model textures are combined incorrectly #10

Open
Awedtan opened this issue Aug 21, 2023 · 2 comments
Open

[Bug] Identical enemy model textures are combined incorrectly #10

Awedtan opened this issue Aug 21, 2023 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Awedtan
Copy link

Awedtan commented Aug 21, 2023

In Arknights for whatever reason, some enemies have the same filenames for their spine images such as enemy_1027_mob and enemy_1027_mob_2. For your project, these images appear separately in the unpacked folder. But when the transparency is applied, the project seems to only use the first one. Could you make it so all the images are processed?

I cant read Python or Chinese very well, but my first guess would be that it's because the alpha image is named "enemy_1027_mob[alpha]_#0" instead of "enemy_1027_mob_#0[alpha]".

Example:
Unpacked folder (red shirt guy is here)
image
Combined folder (red shirt guy is missing)
image

@Awedtan
Copy link
Author

Awedtan commented Aug 21, 2023

I just realized that if you are able to save files based on their actual enemy ID instead of the image filenames, so enemy_1027_mob and enemy_1027_mob_2 are in separate folders, then that would resolve this issue better.

@isHarryh
Copy link
Owner

isHarryh commented Sep 2, 2023

Thank you for your investigation. It is confirm that these enemies can cause this bug :

  • 1027_mob & 1027_mob_2
  • 1036_amraoe & 1036_amraoe_2
  • 1046_agent & 1046_agent_2
  • 1047_sagent & 1047_sagent_2
  • 1049_eagent & 1049_eagent_2
  • 1286_dumcy & 1286_dumcy_2

In these cases, the "_2" model was named without the suffix "_2", so that they are recognized as the "non-2" models by our program. So, the suffix "#0" was automatically added to these different image files in the unpacking stage. However, the skel/atlas files of "_2" and "non-_2" have the same content, so they are not unpacked because of the same-file-conflict.

This circumstance we talking about is a historical problem of Arknights. Your advice is a helpful approach to solve this bug. To temporarily solve this bug, you can manually rename the conflicted files after the unpacking stage.

Internationalization of our Unpacker tool will be carried out in the next versions.

@isHarryh isHarryh added bug Something isn't working good first issue Good for newcomers labels Sep 2, 2023
@isHarryh isHarryh changed the title Identical image filenames are combined incorrectly [Bug] Identical enemy model textures are combined incorrectly Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants