Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Literals are not highlighted nicely in objects #6

Open
theneva opened this issue Oct 26, 2015 · 2 comments
Open

Literals are not highlighted nicely in objects #6

theneva opened this issue Oct 26, 2015 · 2 comments

Comments

@theneva
Copy link

theneva commented Oct 26, 2015

First of all, thank you for this plugin!

I have a suggestion for highlighting in objects. As it stands, everything is purple except non-string keys:

image

The problem becomes especially apparent when the object keys are also strings, as they become the same colour as everything else.

It would be great if the highlighting somehow differentiated between keys, literals (true, false, 10, 4.2), and strings. For example, the default highlighting "solves" this problem by simply ignoring numbers:

image

An even better solution would be greatly appreciated, though.

@isRuslan
Copy link
Owner

@theneva Thanks, for the suggestion!
I will check all around this issue and point here what can we do for this.

@theneva
Copy link
Author

theneva commented Oct 26, 2015

Sweet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants