Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server does not respond with data field in error message if one isnt present on the Error instance in getResult #117

Open
isaacgr opened this issue Oct 13, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@isaacgr
Copy link
Owner

isaacgr commented Oct 13, 2022

error.data = e.data;

This should likely be

error.data = e.message

@isaacgr isaacgr added the bug Something isn't working label Oct 16, 2022
@isaacgr
Copy link
Owner Author

isaacgr commented Oct 16, 2022

Looks like this was fixed in #109 but the implementation is dubious. It assumes that the user is generating the error and adding the 'data' field to that error. It might make more sense that the error message is used unless the error object contains a data field.

So error.data = e.data || e.message

@isaacgr
Copy link
Owner Author

isaacgr commented Oct 16, 2022

This is unfortunately breaking for many of the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant