Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question: does refactor do multiple passes over the codebase until there's no diff? #58

Open
cktang88 opened this issue Aug 26, 2022 · 1 comment

Comments

@cktang88
Copy link

cktang88 commented Aug 26, 2022

for example, in https://refactor.readthedocs.io/en/latest/tutorials/actions.html#replace I see 3 iterations. I'm mostly concerned about the impact this has on performance over large codebases.

@isidentical
Copy link
Owner

@cktang88 that's true, it will run constantly until there is nothing to change.

I'm mostly concerned about the impact this has on performance over large codebases.

This is something that we didn't actively consider in the past with the assumption that a full-run would only happen once a new rule is introduced and then runner frameworks like pre-commit would help them to limit. But we might start allowing a single iteration examples with the addition of chained actions (#57) which would essentially help you to scan and refactor a whole tree in one go.

If you have any performance critical examples, I'd love to hear more about them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants