Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing a decorator_list #73

Open
MementoRC opened this issue Dec 22, 2022 · 0 comments
Open

Replacing a decorator_list #73

MementoRC opened this issue Dec 22, 2022 · 0 comments

Comments

@MementoRC
Copy link
Contributor

MementoRC commented Dec 22, 2022

I encountered a situation where I want to remove some decorators (like replacing aiounittest.async_test with IsolatedAsyncioTestCase). refactor throws the InvalidActionError because it finds that I emptied the list of decorators, as it identified the decorator as critical. On the other hand, i don't want to delete the AsyncFunctionDef just because of the decorator_list
The workaround to that in my branch is to butcher the is_critical_node in order to invalidate the is_critical_node.
Would you suggest a neater way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant