Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a param in the 'SoftImpute' function similar to 'lambda' in 'softImpute' in r? #150

Open
wcanisay-y opened this issue Jul 18, 2023 · 1 comment

Comments

@wcanisay-y
Copy link

Hi! I appreciate this work very much.
However, I notice that in the 'readme.md' file the 'SoftImpute' function is said to be inspired by the [softImpute] package for R, but there is a critical param called 'lambda', which stands for the nuclear-norm regularization parameter: \min||X-M||o^2 +lambda||M||*, not mentioned in this 'SoftImpute' function.
I am wondering whether this param can be manually adjusted if I use the function because it is important to me. Thank you if you can help!

@YagmurGULEC
Copy link

I think it should shrinkage_value. You should initiate SoftImpute(shrinkage_value=0.1). I also implemented SoftImpute based on Julia implementation https://github.com/YagmurGULEC/py-soft-impute/blob/master/soft_impute.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants