-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dragging slides (swipe) with mouse fires click event. #375
Comments
Using 'isSliding' data, I could solve this issue. @slide-start="isSliding = true" Is there any clever way to bypass this click events? |
same problem |
I found this comment, and it works like a charm. |
I can see this library is trying to prevent the event from firing but in a wrong way, it uses a form of .stopPropagation (3rd param of addEventListener) but only when the event has already reached window https://github.com/ismail9k/vue3-carousel/blob/master/src/components/Carousel.ts#L225-L228 This will indeed not prevent a click from firing and it should instead run event.preventDefault() instead of trying to capture the event |
Describe the bug
After upgrade to v0.3.3,
dragging slides (swipe) with mouse fires click event.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
v.0.3.3 : Dragging with mouse is just swipes slides. Not capturing click events.
v0.3.1 : Everything is OK.
Screenshots
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: