Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce the var to delete the kube-proxy so we can test the cilium … #26

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

liyihuang
Copy link
Contributor

introduce the var to delete the kube-proxy so we can test the cilium kpr

@liyihuang liyihuang requested a review from a team as a code owner February 21, 2024 19:58
Copy link
Contributor

@PhilipSchmid PhilipSchmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting the kube-proxy DS might not be enough. IMO that needs to be added as flag to the regarding K8s distio TF module.

@liyihuang
Copy link
Contributor Author

liyihuang commented Feb 21, 2024

I tried it that way the problem is some distio doesn't support you to disable it during the install or I can't find it. I also ran into the other issues with EKS terraform module.

After a few attempts, I think this is almost the best way to implement it. I don't know what else is needed, but my understanding is we delete the kube-proxy ds/cm and delete all the iptable rules for KUBE should be enough. I'm open to any other idea if that's better for us to implement.

https://isovalent.slack.com/archives/C01742ANV9P/p1708306648141849 had some discussion here.

Copy link
Contributor

@PhilipSchmid PhilipSchmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Right, so let's add this as a fallback for precisely those corner cases. Could you please check the nit comment I added and run make docs and terraform fmt before merging? TIA!

variables.tf Show resolved Hide resolved
Copy link
Contributor

@PhilipSchmid PhilipSchmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@liyihuang liyihuang merged commit 9fea206 into main Feb 22, 2024
2 checks passed
@liyihuang liyihuang deleted the pr/liyi/disable_aws_kube_proxy branch February 22, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants