Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading a wfdb record has excessive lead selection #15

Open
Skorik99 opened this issue Jun 18, 2024 · 0 comments
Open

Reading a wfdb record has excessive lead selection #15

Skorik99 opened this issue Jun 18, 2024 · 0 comments
Assignees
Labels
bug Something isn't working Doing

Comments

@Skorik99
Copy link
Collaborator

Skorik99 commented Jun 18, 2024

ecglib.data.dataset.EcgDataset.read_ecg_record method takes leads argument to slice ecg_record when open it with wfdb type. But this slice is excessive because when creating an instance of EcgRecord class it happens again:

full_ecg_record_info = EcgRecord(
            signal=ecg_record[self.leads, :],
            ...
        )

So, the creating an EcgDataset with wfdb signal and custom sequence of leads (for example [0, 5, 6, 7, 8, 9, 10, 11]) it raised an error.

@Skorik99 Skorik99 changed the title Reading a vfdb record has excessive lead selection Reading a wfdb record has excessive lead selection Jun 18, 2024
@Skorik99 Skorik99 self-assigned this Jun 18, 2024
@Skorik99 Skorik99 added bug Something isn't working Doing labels Jun 18, 2024
Skorik99 added a commit that referenced this issue Jun 18, 2024
Skorik99 added a commit that referenced this issue Aug 30, 2024
AvetisyanAram added a commit that referenced this issue Nov 11, 2024
#15: fix excessive lead selection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Doing
Projects
None yet
Development

No branches or pull requests

1 participant